Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped nuget dependencies not all updated #8740

Closed
1 task done
dagstuan opened this issue Jan 9, 2024 · 4 comments
Closed
1 task done

Grouped nuget dependencies not all updated #8740

dagstuan opened this issue Jan 9, 2024 · 4 comments
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working

Comments

@dagstuan
Copy link

dagstuan commented Jan 9, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

nuget

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

No response

dependabot.yml content

https://github.com/dagstuan/skredvarselGarmin/blob/main/.github/dependabot.yml

Updated dependency

No response

What you expected to see, versus what you actually saw

I have a setup where I group nuget dependencies together. Dependabot creates a PR and seemingly identifies all outdated dependencies, yet not all .csproj-files are updated. See example-PR from dependabot here: dagstuan/skredvarselGarmin#133

In this case, most of the updated dependencies are contained in SkredvarselGarminWeb.csproj in another folder, yet the only changed file in the PR is the SkredvarselGarminWeb.Tests.csproj even though the description says that dependabot has updated dependencies in the other .csproj as well.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@dagstuan dagstuan added the T: bug 🐞 Something isn't working label Jan 9, 2024
@hwoodiwiss
Copy link

I'd like to add a +1 to this, only one of the three updates that should have been in this group update were in the final commit.
The dependabot.yml with group for the above PR is here

@jakecoffman jakecoffman added L: dotnet:nuget NuGet packages via nuget or dotnet F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR labels Jan 10, 2024
@kmcc049
Copy link

kmcc049 commented Jan 14, 2024

This is a duplicate of #8576

@sebasgomez238
Copy link
Contributor

@dagstuan and @hwoodiwiss The fix for this was merged yesterday (#9228). Let us know if this fixes your issue. Thanks!

@dagstuan
Copy link
Author

@sebasgomez238 It seems to be working fine now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants