Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y Support] Accessibility Fix Request from Benefits Team 1 #50215

Closed
5 of 16 tasks
kjduensing opened this issue Dec 1, 2022 · 36 comments
Closed
5 of 16 tasks

[a11y Support] Accessibility Fix Request from Benefits Team 1 #50215

kjduensing opened this issue Dec 1, 2022 · 36 comments
Labels
accessibility ghp-admin Needs refining parallel to CMS team label, for issue transfer purposes Public Websites Global Unauthenticated Experience team for va.gov. Products include home page, content hubs... sitewide accessibility sitewide CAIA sitewide CAIA-product support sitewide content CAIA content work sitewide VA.gov frontend Content-build, vets-website, or next-build work

Comments

@kjduensing
Copy link
Contributor

kjduensing commented Dec 1, 2022

Status

[2024-02-27]

  • Laura Flannery verified the list of pages to see if any others need H2; refer to comments for the results.
  • Laura's conclusion: Based on this list (and not including the ones where I couldn't find a Drupal page), H3 does look like it is the correct default heading level - there being 11 H3's and only 9 H2's - there is not an overwhelming majority though. I had to ask Megan Zehnder a question about a page and she mentioned they have been putting more content into widgets so I asked her what she thought would be the more common pattern going forward and she said she would get back to me.

[2024-02-21]

  • Jill Adams reported that the CTA widget is used across several health apps pages (e.g. test results, refill rx, schedule an appt, etc.), and Chris Kim (PW FE Engineer) confirmed this is the same CTA widget code used on our other pages (e.g. Rx refill, secure messaging, etc.). The header level was set to default H3 when this converted to the va-alert DS component:. To use H2 instead, you have to override and pass that in.

CAIA Assignees

  • CAIA Team Member 1
  • CAIA Team Member 2 (if needed)

What does your team need support for? Check all that apply.

  • Launching one or more new unauthenticated (static) VA.gov pages
  • Making revisions to one or more existing unauthenticated (static) VA.gov page
  • Launching a new online form, app, or tool on VA.gov
  • Making revisions to an existing online form, app, or tool on VA.gov
  • Something else (please add details in the next question)

What do you need help with?

  • Content support
  • IA support

Please be specific about the content or IA support you need and provide any additional documents and/or links that will help us help you. If we need to add a react widget to a page, be sure to provide the code here.

We found in an accessibility audit that the organization of headings was not ordered logically for users with screen readers. We're looking for someone to change the heading levels on the <SignIn/> CTA Widget and the va-detailpage-sidebar to be more accessible to folks using screen readers. I've attached a screenshot of the Headings Map tool output:
image. Please also see the linked ticket under the Supporting Artifacts section

Specifically:

  1. The "Sign in" CTAWidget heading should be an <h2/> instead of an <h3/>.
  2. "Download your VA letters on your mobile device..." should be an <h3/>, not a <h2/>

Please feel free to reach out if y'all need more info. Thank you!

Will this new product be released incrementally (for instance 25% of users initially)?

  • Yes
  • No
    (Not a new product)

Note: If you checked yes, we'll reach out to discuss details about the content in the react widget.

When do you expect to launch your product to 100% of users?

Please provide an estimated date so our team can create other relevant tickets.

Supporting artifacts

Please provide supporting artifacts as available.

Will this work be going through the Collaboration Cycle?

  • Yes
  • No

When does this work need to be done?

  • Estimated launch date: n/a
  • Estimated staging review date: n/a
  • Content and IA work needed by: No date specified, but this has been flagged as a "serious accessibility issue"

Do you plan to bring this to an upcoming content office hours session?

  • Yes, benefit content office hours (Thursdays, 3:00 p.m. to 3:45 p.m. ET)
  • Yes, health content office hours (Thursdays, 11:00 a.m. to 11:30 a.m. ET)
  • Yes, unauth office hours (Mondays, 11:00 a.m. to 11:30 a.m. ET)
  • No, but I'd like to schedule time to talk about this request
  • No, let's work asynchronously and meet if needed

Note: If we think this work would benefit from a collaborative session with you, we may ask you to bring it to office hours or set up a separate time to meet.

About your team

  • Team name:
  • OCTO-DE product owner: Matt Self
  • Product manager: Jacob Worrell
  • Designer: Skyler Schain
  • FE engineer: Kevin Duensing
  • Product/team Slack channel: https://dsva.slack.com/archives/C5AGLBNRK
  •   Accessibility Lead: Josh Kim
    

Next steps

Once you’ve submitted this ticket, please post a link to this issue in the #sitewide-content-ia Slack channel and tag Randi Hecht.

If you also need engineering support from the Public Websites team, fill out their intake request form.

If you need a page/URL redirected, a URL changed or a vanity URL set up, please submit a Redirect, URL change, or vanity URL request

@kjduensing kjduensing changed the title <Type of Request> from <Team> Accessibility Fix Request from Benefits Team 1 Dec 1, 2022
@kjduensing
Copy link
Contributor Author

@RLHecht I know y'all are busy, would you mind sharing a quick status update when you get the chance? Thanks!

@RLHecht
Copy link
Contributor

RLHecht commented Jan 13, 2023

Hi @kjduensing the sign-in widget is not something our team manages. I believe this is in the design system as an H3 so would need to be changed universally.

We also didn't create the mobile device alert in drupal. It was created by the mobile team and we added it to the static page. So we wouldn't be able to fix this one either unfortunately.

@RLHecht
Copy link
Contributor

RLHecht commented Jan 25, 2023

@kjduensing Let me know if i should close this out or take it off our board. Thanks!

@joshkimux
Copy link
Contributor

@RLHecht got it! I'll write up a bug ticket for the DST

@joshkimux
Copy link
Contributor

joshkimux commented Mar 13, 2023

@kjduensing @RLHecht , it looks like they may have updated this to a h2 in the design system. Not an engineer by any means, but is this a matter of just refreshing the component we're using? Not sure why it's rendering as a h3 when the source should be a h2 😕

@joshkimux
Copy link
Contributor

@kjduensing @RLHecht small bump on this; would y'all or anyone y'all know have an answer to the prior question? I can also try to ask in the design system channel.

@RLHecht
Copy link
Contributor

RLHecht commented Apr 27, 2023

That sounds right to me, but also not an engineer so I'm not sure how this gets fixed! We can put in a new sign-in widget if someone can tell us the app code we'll need. Though I don't know if that's what's needed.

@kjduensing
Copy link
Contributor Author

So small caveat - I'm not real familiar with the design system components. That said, looking at the docs, it appears you can specify the html tag of your choosing for the headline (Stories -> "View code" on any of the examples):

<va-alert>
  <h2 slot="headline">
    Track your claim or appeal on your mobile device
  </h2>
  
  // ...

</va-alert>

My take on this is whoever owns the sign in widget has rendered this va-alert with an h2 instead of an h3.

Hope it helps!

@kjduensing
Copy link
Contributor Author

Actually, it might go deeper than that. The hierarchy of components is extremely customizable all the way down, which is great in some ways, but makes it difficult to track down exactly where the headingLevel property is set.

@joshkimux
Copy link
Contributor

My take on this is whoever owns the sign in widget has rendered this va-alert with an h2 instead of an h3.

This is fantastic @kjduensing ! Dumb question here on the download letters page

  1. given that the sign in widget should be rendered as a h2, is there a reason why it's showing up as a h3 on this page?
  2. and if we can fix it, who would be able to track down where it is and adjust it on this page specifically?

Screenshot 2023-04-27 at 10 51 03 AM

@kjduensing
Copy link
Contributor Author

kjduensing commented Apr 27, 2023

  1. Ah I see where I was unclear, thanks for the redirect. What we're seeing here isn't a bug - the code is behaving as it was written. The sign in widget allows anyone who uses it to make the title whatever header level they want. So it isn't that the title is being rendered incorrectly due to a bug, it's that the title is actually an h3 in the code.
  2. What we'd need to do to fix this is find the code that is setting the header level to an h3 and simply change it to an h2. The change is trivial, but there are some challenges:
    • Finding where this code is is harder than I thought
    • When I do find the code, is it localized or would changing the code have a broader impact across the site?
    • If changes have a broad impact, who should be responsible for fixing this?

@joshkimux
Copy link
Contributor

@jamigibbs and @Mottie this might be a long shot, but by any chance do either of you have answers to Kevin's second question?

@jamigibbs
Copy link

@joshkimux If this is the va-alert component, then the way to change the header element for the "Sign in to get your...." text would be to use the headline slot with whichever header size needed.

This is wha @kjduensing mentioned above: #50215 (comment)

If we're unsure if this is va-alert, can you provide a link to where this is located? I'll be happy to inspect and confirm.

@kjduensing
Copy link
Contributor Author

I can confirm this is a va-alert :)

@Mottie
Copy link
Contributor

Mottie commented Apr 27, 2023

That page looks like it's a static content page, so you'd have to report the problem to the sitewide content people. I remember someone mentioned that they reported the H4 placed before the H1, but I can't find the reference

@joshkimux
Copy link
Contributor

@RLHecht do you know of any engineers on the sitewide content team this could be assigned to?

@Mottie
Copy link
Contributor

Mottie commented Apr 27, 2023

Oh wait, that's using the standard call to action widget - I haven't dived into that code, but here is where the letters app is defined. The call to action alert code does include a headerLevel.

Update: Whatever calls the cta-widget code is passing in a headerLevel prop

@kjduensing
Copy link
Contributor Author

Right, @Mottie, but what's calling the CTA widget? I wasn't able to tell what sets the actual headerLevel prop..

@sara-amanda
Copy link
Contributor

@RLHecht or @SarahKay8 , do you know who we should best route this to?
cc: @coforma-terry

@sara-amanda sara-amanda changed the title Accessibility Fix Request from Benefits Team 1 [a11y Support] Accessibility Fix Request from Benefits Team 1 Sep 12, 2023
@eli-oat
Copy link
Contributor

eli-oat commented Sep 14, 2023

Uncertain who owns this code. Not sure about the next steps.

CAIA to check in with DST on Slack.

@coforma-terry
Copy link
Contributor

Hey @eli-oat - did DST shed any light on who owns this code?

@eli-oat
Copy link
Contributor

eli-oat commented Dec 11, 2023

@coforma-terry followed back up for further info in the DST channel

@eli-oat
Copy link
Contributor

eli-oat commented Dec 11, 2023

@coforma-terry -- per DST, this is owned by the public websites/sitewide team.

@coforma-terry
Copy link
Contributor

@strelichl - we need to transfer this to public websites to implement 👍

@FranECross
Copy link
Contributor

@coforma-terry @strelichl Added to our next refinement to review. Thanks!

@jilladams
Copy link
Contributor

@laflannery FYSA, since this is about header levels. The CTA widget is used across several health apps pages (e.g. test results, refill rx, schedule an appt, etc.). I'm not certain if the header levels are set per page where it's called, or once and for all. We'll need to think about that during this ticket.

@jilladams jilladams added Public Websites Global Unauthenticated Experience team for va.gov. Products include home page, content hubs... VA.gov frontend Content-build, vets-website, or next-build work labels Feb 20, 2024
@jilladams
Copy link
Contributor

From FE refinement:

Qs:

@laflannery
Copy link
Contributor

laflannery commented Feb 27, 2024

Un-auth heading levels:

I can't find Drupal Pages for the below. The only pages I can find that have the widget aren't in Drupal so I might have the wrong page or maybe these got moved away from PW, maybe?:

Based on this list (and not including the ones where I couldn't find a Drupal page), H3 does look like it is the correct default heading level - there being 11 H3's and only 9 H2's - there is not an overwhelming majority though. I had to ask Megan Zehnder a question about a page and she mentioned they have been putting more content into widgets so I asked her what she thought would be the more common pattern going forward and she said she would get back to me.

@FranECross
Copy link
Contributor

  • Per Jill we own the disability rating tool.
  • Need to look at the list to see which we own and which we don't.

@strelichl
Copy link
Contributor

@FranECross are we ok to close this?

@FranECross
Copy link
Contributor

@laflannery Based on your last comment and research, is there work for the PW team (or a different team) to do on this ticket, or may it be closed? cc @strelichl @jilladams

@laflannery
Copy link
Contributor

@FranECross It would depend on if the headings are correct on all the widgets we own

@strelichl
Copy link
Contributor

@FranECross I'm assuming your thumbs up means widgets are good to go and we can close? Just want to make sure!

@FranECross
Copy link
Contributor

@strelichl Apologies for the confusing thumbs up. 😉 I was just acknowledging Laura's note and believe we'll need to review the headings on the widgets we own to ensure they are correct. I've added this to my task list and will follow up.

@laflannery
Copy link
Contributor

Talked to Michelle, I'm going to make individual tickets for all the headings that need changing so they can easily be pulled into sprints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility ghp-admin Needs refining parallel to CMS team label, for issue transfer purposes Public Websites Global Unauthenticated Experience team for va.gov. Products include home page, content hubs... sitewide accessibility sitewide CAIA sitewide CAIA-product support sitewide content CAIA content work sitewide VA.gov frontend Content-build, vets-website, or next-build work
Projects
None yet
Development

No branches or pull requests