Calvin/appeals 29522 hide legacy tasks #19341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 4af6484 and detected 116 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
MuhGrayVA
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-29522
Description
Changed how hide_legacy_tasks works, so we could simply identify the scenarios where we would want to hide legacy tasks in case details.
Acceptance Criteria
Testing Plan
Steps to Reproduce:
Generate a Scenario1Edge Task using the rake generator, then enter the case details of one of the generated cases.
Previous Results:
Cases with blocking tasks such as Foia tasks, they will not show the legacy task due to the current conditions to hiding legacy tasks in the task_for_appeal.rb file
New Results:
Any blocking tasks on these scenarios will also appear with the distribution task and any legacy task
Frontend
User Facing Changes
Scenario 1 - Shows legacy tasks ✔️
Scenario 1 Edge - Shows legacy tasks ✔️
Scenario 2 - Shows legacy tasks ✔️
Scenario 3 - Does not show legacy tasks ✔️
Scenario 4 - Does not show legacy tasks ✔️
Scenario 6 - Does not show legacy tasks ✔️
