Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed attorney_case_review and case_review_controller specs #19303

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Fixed attorney_case_review and case_review_controller specs #19303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f4dc74
Fixed attorney_case_review and case_review_controller specs
samasudhirreddy Aug 29, 2023
fa2cb16
Merge branch 'feature/APPEALS-24914' into Sudhir/APPEALS-29311-Rspecs
cacevesva Aug 30, 2023
1f714d3
Merge branch 'feature/APPEALS-24914' into Sudhir/APPEALS-29311-Rspecs
cacevesva Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/attorney_case_review.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def complete(params)
ActiveRecord::Base.multi_transaction do
record = create(params)
if record.valid?
if record.legacy? && record.task.type == "AttorneyTask"
if record.legacy? && record&.task&.type == "AttorneyTask"
record.update_in_vacols_and_caseflow!
else
record.legacy? ? record.update_in_vacols! : record.update_in_caseflow!
Expand Down
2 changes: 1 addition & 1 deletion spec/models/tasks/judge_dispatch_return_task_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
[
Constants.TASK_ACTIONS.ADD_ADMIN_ACTION.to_h,
Constants.TASK_ACTIONS.TOGGLE_TIMED_HOLD.to_h,
Constants.TASK_ACTIONS.REASSIGN_TO_JUDGE.to_h,
Constants.TASK_ACTIONS.REASSIGN_TO_LEGACY_JUDGE.to_h,
Constants.TASK_ACTIONS.JUDGE_AMA_CHECKOUT.to_h,
Constants.TASK_ACTIONS.JUDGE_DISPATCH_RETURN_TO_ATTORNEY.to_h,
Constants.TASK_ACTIONS.CANCEL_TASK.to_h
Expand Down
Loading