msteele/APPEALS-28954

[msteele96]

Resolves APPEALS-28954

Description

Added efolder url field to be present when changing task to a HPR or HWR type and adjusted styling of efolder url field to allow loading spinner to not overlap with text.

Acceptance Criteria

Whenever a user executes the "Change task type" task action on any mail task
If they select "Hearing postponement request"
The user is required to enter the following:
The URL for an eFolder document
This field should just accept a string
Instructions and context
Allowable characters include alphanumeric and special characters
The submission button remains disabled until all of the above criteria is met.
The user can cancel action to add the task at any time before submitting it
The user can submit action to add the task
Upon submitting the action, the following occurs:
If the URL entered by the user has a corresponding document in eFolder
The task is added with the following attributes:
Assigned on: < date task created >
Assigned to: “Hearing Admin”
Assigned by: < user who added the task >
Task: “Hearing postponement request”
Task instructions: < URL entered by the user plus instructions and context entered by the user >
If they select any other task type
The modal's behavior should remain the same.

Testing Plan

1. Go to https://jira.devops.va.gov/browse/APPEALS-29327 and https://jira.devops.va.gov/browse/APPEALS-29328

Frontend

User Facing Changes

• Screenshots of UI changes added to PR & Original Issue

BEFORE|AFTER

Best practices

Code Documentation Updates

• Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

• RSpec
• Jest
• Other

Code Climate

Your code does not add any new code climate offenses? If so why?

• No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

• Are performance metrics (e.g., response time, throughput) being tracked?
• Are key application components monitored (e.g., database, cache, queues)?
• Is there a system in place for setting up alerts based on performance thresholds?

Logging

• Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
• Are logs structured (e.g., using log tags) for easier querying and analysis?
• Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
• Is log retention and rotation configured correctly?
• Are logs being forwarded to a centralized logging system if needed?

Auditing

• Are user actions being logged for audit purposes?
• Are changes to critical data being tracked ?
• Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

• Are errors being caught and handled gracefully?
• Are appropriate error messages being displayed to users?
• Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
• Are unhandled exceptions being caught at the application level ?

Exception Handling

• Are custom exceptions defined and used where appropriate?
• Is exception handling consistent throughout the codebase?
• Are exceptions logged with relevant context and stack trace information?
• Are exceptions being grouped and categorized for easier analysis and resolution?

[codeclimate]

Code Climate has analyzed commit 6a909ff and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1
Style	1

Note: there is 1 critical issue.

View more on Code Climate.

[ThorntonMatthew]

Fantastic work!