Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webex Mock Service APPEALS-28105 #19266

Merged
merged 36 commits into from
Aug 29, 2023
Merged

Conversation

breedbah
Copy link
Contributor

@breedbah breedbah commented Aug 25, 2023

Resolves APPEALS-28105

Description

  • Created a Mockservice for to create Webex conference links

  • Added error handling for if the request body is missing and keys

  • Added error handling for if any params are missing

  • Created a generator to be able to create large sets of mock data

  • Added fake data using the Faker library

  • Added all error responses 400's and 500's given for webex

  • Added a heartbeat json response

  • Readme.md created to asssist in installation and operation

  • Appropriate file added to .gitignore so, unnecessary large amounts of fake data are not committed to github

  • Code compiles correctly

Testing Plan

  1. Go to APPEALS-28105/Test Plan Link
  • For feature branches merging into master: Was this deployed to UAT?

Integrations: Adding endpoints for external APIs

  • Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
  • Update Fakes

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

breedbah and others added 30 commits August 14, 2023 13:08
@breedbah breedbah changed the title B_reed/APPEALS-28105 b_reed/APPEALS-28105 Aug 25, 2023
@breedbah breedbah changed the title b_reed/APPEALS-28105 Webex Mock Service b_reed/APPEALS-28105 Aug 25, 2023
@breedbah breedbah changed the title Webex Mock Service b_reed/APPEALS-28105 Webex Mock Service APPEALS-28105 Aug 25, 2023
@breedbah breedbah added Team: Oumuamua ☄️ Development Team for the Hearings ART Project: Virtual-Hearings labels Aug 25, 2023
@breedbah breedbah self-assigned this Aug 25, 2023
@breedbah breedbah marked this pull request as ready for review August 25, 2023 19:38
mchbidwell
mchbidwell previously approved these changes Aug 28, 2023
Copy link
Contributor

@mchbidwell mchbidwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this test is failing test/app/queue/organizationUsers/OrganizationUsers.test.js

@breedbah breedbah requested a review from mchbidwell August 29, 2023 14:05
@mchbidwell mchbidwell merged commit 51df414 into feature/APPEALS-26734 Aug 29, 2023
10 of 14 checks passed
@mchbidwell mchbidwell deleted the b_reed/APPEALS-28105 branch August 29, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: Virtual-Hearings Team: Oumuamua ☄️ Development Team for the Hearings ART
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants