-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webex Mock Service APPEALS-28105 #19266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of-veterans-affairs/caseflow into b_reed/APPEALS-28105
breedbah
changed the title
b_reed/APPEALS-28105
Webex Mock Service b_reed/APPEALS-28105
Aug 25, 2023
breedbah
changed the title
Webex Mock Service b_reed/APPEALS-28105
Webex Mock Service APPEALS-28105
Aug 25, 2023
breedbah
added
Team: Oumuamua ☄️
Development Team for the Hearings ART
Project: Virtual-Hearings
labels
Aug 25, 2023
mchbidwell
previously approved these changes
Aug 28, 2023
mchbidwell
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this test is failing test/app/queue/organizationUsers/OrganizationUsers.test.js
mchbidwell
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-28105
Description
Created a Mockservice for to create Webex conference links
Added error handling for if the request body is missing and keys
Added error handling for if any params are missing
Created a generator to be able to create large sets of mock data
Added fake data using the Faker library
Added all error responses 400's and 500's given for webex
Added a heartbeat json response
Readme.md created to asssist in installation and operation
Appropriate file added to .gitignore so, unnecessary large amounts of fake data are not committed to github
Code compiles correctly
Testing Plan
Integrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Error Handling
Exception Handling