Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPEALS-23450 #19166

Merged
merged 4 commits into from
Aug 31, 2023
Merged

APPEALS-23450 #19166

merged 4 commits into from
Aug 31, 2023

Conversation

Blake-Manus
Copy link
Contributor

@Blake-Manus Blake-Manus commented Aug 10, 2023

Resolves #{23450}
APPEALS-23450

Description

  • Creates functionality that allows Remand Reasons to be filtered from being selectable for Remanded Legacy Issues.
  • Places the "BVA Travel Board and Hearing" checkbox selection in Legacy Remand Reasons behind the appropriate feature flag.

Acceptance Criteria

  • Code compiles correctly
  • The "BVA Travel Board and Hearing" should not display in Legacy Remand Reasons if the feature flag is enabled.
  • The new functionality should be available when the feature flag is toggled.
  • The old functionality should be available when the feature flag is not toggled.

Testing Plan

  1. Go to #{23450} APPEALS-23450
  2. Check out the latest code
  3. Log into BVAAABSHIRE for Judge Workflow or BVASCASPER1 for Attorney Workflow
  4. Ensure that the feature flag "additional_remand_reasons" is added or removed for testing each functionality.
  5. Go to Queue
  6. Select a Legacy Appeal in Review and choose "Ready for Dispatch" (Judge) or "Decision Ready For Review" (Attorney)
  7. Select "No Special Issues" and Continue
  8. Select "Remanded" for one or more issues, and Continue
  9. On the Select Remand Reasons page, the following should happen
  • "BVA Travel Board and Hearing" Should display if the feature flag is NOT enabled
  • "BVA Travel Board and Hearing" Should NOT display if the feature flag IS enabled.,
  1. Select a remand reason and complete the process, ensuring no completion issues.

Expected Result:

  • The "BVA Travel Board and Hearing" should not display in Legacy Remand Reasons if the feature flag is enabled.
  • The new functionality should be available when the feature flag is toggled.
  • The old functionality should be available when the feature flag is not toggled.

Frontend

User Facing Changes

Screenshot 2023-08-17 at 1 06 22 PM Screenshot 2023-08-17 at 1 05 53 PM

@Blake-Manus Blake-Manus marked this pull request as ready for review August 17, 2023 20:39
@Blake-Manus Blake-Manus requested a review from kristeja August 17, 2023 20:39
@kristeja kristeja merged commit 45c34fc into feature/APPEALS-20492 Aug 31, 2023
@ThorntonMatthew ThorntonMatthew deleted the ricky/APPEALS-23450 branch November 21, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants