-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix/APPEALS-25321 and APPEALS-25955 #19030
Merged
ThorntonMatthew
merged 50 commits into
master
from
hotfix/APPEALS-25321-and-APPEALS-25955
Aug 30, 2023
Merged
hotfix/APPEALS-25321 and APPEALS-25955 #19030
ThorntonMatthew
merged 50 commits into
master
from
hotfix/APPEALS-25321-and-APPEALS-25955
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same setup code.
…ve been joining on the wrong id.
…APPEALS-25282 TYLERB/APPEALS-25282
* master: (308 commits) Update MAC_INTEL.md (#18997) Fix flake spec "access the appeal's case details" (#18981) Craig/appeals 24719 (#18987) Revert Removed the skip tag from docket_spec.rb spec test (#18984) Reinstate MTV changes Fix spelling error Ensured original responses show in dropdown for swagger ui removing flake test (#18982) 551ced7 Tweaks error cleanup Added routes to outcode half of error scenarios Other upload Add to other upload addresses Treat lines as errors Last name First name ...
…of-veterans-affairs/caseflow into hotfix/APPEALS-25321
…ans-affairs/caseflow into hotfix/APPEALS-25321 * 'hotfix/APPEALS-25321' of github.com:department-of-veterans-affairs/caseflow: Use stub_consts in place of simply overriding constants Possible bug fix to the sql query for appeals_not_synced. It might have been joining on the wrong id. Merged 3 tests with 3 different expects into one test since they use the same setup code.
…x/APPEALS-25321-and-APPEALS-25955
…APPEALS-25321 Hotfix/appeals 25321
Code Climate has analyzed commit e9610d0 and detected 0 issues on this pull request. View more on Code Climate. |
…o hotfix/APPEALS-25321-and-APPEALS-25955
…1-and-APPEALS-25955
…1-and-APPEALS-25955
…1-and-APPEALS-25955
msteele96
reviewed
Aug 30, 2023
.github/workflows/workflow.yml
Outdated
Comment on lines
247
to
248
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove to get rid of diff
msteele96
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-25321
Description
Prevents duplicate notification reports from being uploaded to eFolder for recently outcoded appeals.
Acceptance Criteria
Testing Plan