Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/APPEALS-25321 and APPEALS-25955 #19030

Merged
merged 50 commits into from
Aug 30, 2023

Conversation

ThorntonMatthew
Copy link
Contributor

@ThorntonMatthew ThorntonMatthew commented Jul 19, 2023

Resolves APPEALS-25321

Description

Prevents duplicate notification reports from being uploaded to eFolder for recently outcoded appeals.

Acceptance Criteria

  • Code compiles correctly
  • Duplicate upload cease for recently outcoded appeals.

Testing Plan

  1. Go to APPEALS-27317 or list them below
  • For feature branches merging into master: Was this deployed to UAT?

TylerBroyles and others added 28 commits July 12, 2023 17:10
* master: (308 commits)
  Update MAC_INTEL.md (#18997)
  Fix flake spec "access the appeal's case details" (#18981)
  Craig/appeals 24719 (#18987)
  Revert
  Removed the skip tag from docket_spec.rb spec test (#18984)
  Reinstate MTV changes
  Fix spelling error
  Ensured original responses show in dropdown for swagger ui
  removing flake test (#18982)
  551ced7
  Tweaks
  error cleanup
  Added routes to outcode
  half of error scenarios
  Other upload
  Add to other upload
  addresses
  Treat lines as errors
  Last name
  First name
  ...
…ans-affairs/caseflow into hotfix/APPEALS-25321

* 'hotfix/APPEALS-25321' of github.com:department-of-veterans-affairs/caseflow:
  Use stub_consts in place of simply overriding constants
  Possible bug fix to the sql query for appeals_not_synced. It might have been joining on the wrong id.
  Merged 3 tests with 3 different expects into one test since they use the same setup code.
@codeclimate
Copy link

codeclimate bot commented Jul 19, 2023

Code Climate has analyzed commit e9610d0 and detected 0 issues on this pull request.

View more on Code Climate.

@ThorntonMatthew ThorntonMatthew marked this pull request as ready for review August 3, 2023 18:07
Comment on lines 247 to 248


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove to get rid of diff

@ThorntonMatthew ThorntonMatthew merged commit 21f455f into master Aug 30, 2023
12 of 14 checks passed
@ThorntonMatthew ThorntonMatthew deleted the hotfix/APPEALS-25321-and-APPEALS-25955 branch August 30, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants