Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
backmerge master to feature/APPEALS-19847 (#19358)
* hid pact and mst check behind toggles * added caching to BGS contention call * updated feature toggles to include current user * adding logging for BGS contention calls * Added toggle to index.html.erb * Progress on conference types radio field * added 24 hr caching and commented out toggle for bgs call * adding conference type selection logic * APPEALS-25141: created migrations to add pexip bool column to users virtual hearings and conference links * APPEALS-25141: set default value to true on users * Work on radio field selection * Fixed errors with conference selection radio field * laurenoelle/APPEALS-19871 initial files * APPEALS-17497: MST & PACT Special issues identification * Clean up code after new import file * optimized participant contentions method to return contentions to cut down on BGS calls * added feature toggle guard clause for bgs calls for ratings * hid pact and mst check behind toggles * added caching to BGS contention call * updated feature toggles to include current user * adding logging for BGS contention calls * added 24 hr caching and commented out toggle for bgs call * Update copy file and state * hid blue water and burn pit behind mst/pact toggle * APPEALS-25112 Added styling for radio field component * Fixing error with .pick * Fixing .pick * APPEALS-25130 updated user.rb * APPEALS-25141: rolling back changes, creating new migrations, deleting the old, to meeting type varchar default on users only * added toggle for mst on special issues list * APPEALS-25141: removed version 5.2 from migrations * routed judge/attorney decisions to special issues pending on mst pact toggle * updated back button routing and special issues showing on decisions for ama appeals * hid mst pact special issues banner behind feature toggles * Account for failures in ready for resync * HunJerBAH APPEALS-26881: Reject Unknown Attributes in RatingDecisions Hash (#19072) * added handling for unknown attributes being added into rating decision hash * updated paren grouping * Update open_hearing_tasks_without_active_descendants_checker_spec.rb * Adding a rails initializer for monitoring deprecation warnings * Create jest test * allow slack notifications in uat * Test passing * Fixed syntax errors from merged code * Radio buttons fixed to only display on Hearings Admin page * Wrap li elements in ul elements * Test that radio button values change when selected * Update to testing logic with radio buttons * Add ro-colocated examples * Modifying jest tests * APPEALS-25141: refactoring migrations to include up/down methods, adding default for virt hearings and conf links * Fix ro-colocated request body * aaron/APPEALS-25478 (#19070) * APPEALS-25478 Added unit tests to BatchProcessRescueJobSpec to increase code coverage to 100%. * APPEALS-25478 Added unit tests to BatchProcessRescueJobSpec to increase code coverage to 100%. * APPEALS-25478 Added Senty Alert when a record is declared stuck. * APPEALS-25478 Refactered and Updated PriorityEndProductSyncQueueSpec file to have 100% complete code coverage. * APPEALS-25478 Refactor and Linting of batch_process_priority_ep_sync_spec.rb. * APPEALS-25478 Added to batch_process_priority_ep_sync_job_spec.rb to achieve 100% code coverage. * APPEALS-25478 Removed unintentional SImple Cov line in RSPEC. * APPEALS-25478 Updated batch_process_spec.rb to bring code coverage up to 100%. * APPEALS-25478 Updated ENV variable names to ensure uniqueness. * APPEALS-25478 Updated Error messages to include unique identifiers in batch_process_priority_ep_sync.rb. * APPEALS-25478 Added RSPEC for the CaseflowStuckRecord model. * APPEALS-25478 Updated RSPEC for PopulateEndProductSyncQueueJob so that it has 100% code coverage. * APPEALS-25478 Removed table lock from find_records method. * APPEALS-25478 Removed accidental changes to issue_spec.rb * APPEALS-25478 Updated method naming conventions to be more explicit and readable. * APPEALS-25478 Fixed failing RSPEC priority_end_product_sync_queue_spec.rb. * APPEALS-25478 Added additional tests to batch_process_priority_ep_sync_spec.rb. * APPEALS-25478 Updated Code Comments. * APPEALS-25478 Fixed Typo on code comment. * add exception handling to audit remove script * Change address_line_1 to nullable: true * Add migration * Allow audit table entry for address_line_1 to have null val * test update to yarn dependency cache keys * Take setup-node for a spin * Revert "Take setup-node for a spin" This reverts commit 337ea0a. * Add a spec * Fix whitespace * Remove flipper tables * Styling comments updated after review * unskip test (#19076) Co-authored-by: Craig Reese <[email protected]> * Revert 'Merge pull request #19038 from department-of-veterans-affairs/b_reed/APPEALS-25130-v3' This reverts commit ab8ce3c, reversing changes made to 6fc2c0f. * hotfix/APPEALS-27124 Updated MailRequestValidator and VbmsDistributionDestination spec for derived destinations * updated deserialize method to check on rating decision model for attributes in hash * Fixed linting issues and updated jest snapshot * Add class checks for ro-colocated? * Craig/test yarn cache (#19096) modify .github/workflows/workflow.yml * exclude db/scripts in codeclimate (#19103) * Revert "APPEALS-17497: MST & PACT Special issues identification" * Use case * Updated language following feedback from UX team * remove z-index * add z-index * Update webdrivers * Revert "Update webdrivers" This reverts commit 7cd71cd. * APPEALS-17497 MST & PACT Special issues identification changes * Adding Subscriber to monitor deprecation warnings * Add spec file for deprecation warnings * Test wait * Reverse test update * APPEALS-27327: MST and PACT BGS Fix (#19116) * added grouping for feature toggles * moved special issue deserialization for ratings into contestable issue model and added datadog incrementing for reporting * added wildcard to datadog counters and removed redundant logging in bgs_service * APPEALS-25141: updated user_spec.rb * updated data dog service logging * Delete deprecation_alerts.rb * test adding assertion (#19127) * test adding assertion * added assertion to more tests * APPEALS-26633 Added method to update meeting_type in Users Controller, and updated Organizations User model with new method to change meeting_type * Add in FT * APPEALS-26633 Progress on linking backend and frontend radio option changes and added modifyConferenceTypes * Apply suggestions from code review Co-authored-by: Jeremy Croteau <[email protected]> * Update deprecation_warning_subscriber_spec.rb * add concurrency to workflow.yml (#19136) * add concurrency to workflow.yml * Fix typo * APPEALS-26633 Framing for logic to link onChange function * eli/APPEALS-27096 (#19140) * add external-db-create check to avoid error when running command * priority_ep_sync_batch_process_job * populate_end_product_sync_queue_job * priority_ep_sync_batch_process * config/environments/development ENVs * config/environment/test ENVs * scheduled_jobs => BatchProcessPriorityEpSync name change * factories/vbms_ext_claim => duplicate claim_id fix * batch_process_priority_ep_sync_job_spec * priority_end_product_sync_queue_spec * priority_ep_sync_batch_process_spec * batch_process_spec * rename batch process job spec and batch process model spec * caseflow_stuck_records_spec * populate_end_product_sync_queue_job_spec * priority_ep_sync_batch_process_job_spec * batch_process_rescue_job_spec * APPEALS-27096 Updated Schema file. * APPEALS-27096 Added Batch Process & PEPSQ ENV variables to demo. * APPEALS-27096 Added migration to add columns to caseflow_stuck_records and updated schema file. --------- Co-authored-by: Jeffrey Aaron Willis <[email protected]> * 🐛 Pre-emptive bugfix - TypeError Exception: allocator undefined for Thread::Backtrace::Location * 🔊 Log additional metadata to Sentry on deprecation warnings * aaron/APPEALS-27497 (#19139) * APPEALS-27947 Added Audit Removal scripts for table, function, and trigger. * APPEALS-27497 Moved Audit files to appropriate locations. Updated Makefile to reflect changes to audit file locations. * APPEALS-27497 Fixed Indentation in Makefile. * Updated for AC as of August 8 * commented out bgs call and adding logging for production * Fixed spacing * added data dog logging for fetch rating profile and ratings in range * Adding modifyConferenceType to patch to backend * updated contentions response to handle blank? responses in addition to nil? * 🚨 Lint: Remove trailing whites space c * 🥅 Add blanket rescue to DeprecationWarningSubscriber (Puts on tin foil hat) Prevent potential exceptions from SlackService from impacting user experience * ✏️ Fix typo in test description * 🧪 Fix test so that it will pass in non-'test' environments as well * put in explicit nil return statement for contention BGS call testing. * aaron/APPEALS-27780 (#19160) * APPEALS-27780 Added Priority End Product Sync Queue ID to Priority End Product Sync Queue Audit table. Updated trigger function to account for this. * APPEALS-27780 Fixed drop_priority_end_product_sync_queue_audit_trigger.rb * APPEALS-27780 Changed Job Duration Constants for Priority Ep Sync Batch Process Job and Populate End Product Sync Queue Job to minutes from hours. * 🩹 Address deprecation on affected usages of 'order' method DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s) * Eli/APPEALS-27996 (#19170) * APPEALS-27996 => updated command 'make audit' to build tables together, then functions together, then triggers together * APPEALS-27996 => removed whitespace at the top of create_caseflow_stuck_records migration file * APPEALS-27996 => deleted folder 'external_modals', added folder 'external_models' and added vbms_ext_claim.rb to it * APPEALS-27996 => added index creation to create_vbms_ext_claim_table.sql * Update deprecation_warning_subscriber.rb * Revert "Update deprecation_warning_subscriber.rb" This reverts commit 50bf09f. * use env variable for efolder express url * add efolder url env variable to demo environmentt * Add meeting_type to user to capture new meeting type from frontend, debugging in byebug * Hotfix/appeals 27980 NightlySyncsJob (#19173) * add error handling to sync_vacols_cases * add test for sync_bgs_attorneys method * add slack notification on job error, add tests * codeclimate * codeclimate * Fixed bug so frontend hearings change is persisted to backend and updates user meeting type * Revert "APPEALS-17497 MST & PACT Special issues identification" * ✨ Raise error on disallowed deprecations in dev/test envs * Fixed linting issues and added rspec test to check the new meeting type * Add information about patch response test * Fix code climates issues * ✨ Replace 'DeprecationWarningSubscriber' with 'DeprecationWarnings' handlers This will allow us to better tailor handling of deprecation warnings to each environment * 💡 Update comment * 🚨 Lint * 🔥 Remove copy-pasta from pecs * 🚨 Lint II * 🚨 Lint III * Jest testing fixed to check for changing values by radio button selection * Pamatya/APPEALS-24131: Fix flaky/skipped tests in models/idt/token_spec.rb (#19208) * removing the xit and adding new test * Added a test for an expired key for the Idt::Token active method * APPEALS-24131: removed unused let statement * Removed the sleep statement from the test. * Included a docket_spec test fix as well. --------- Co-authored-by: = <[email protected]> * Remove skipped and unneeded feature test (#19214) This will be explained more in the accompanying PR but this test has been skipped for a couple years and does not need to be in the code base anymore as it does not add any value. * APPEALS-24145 Fix test scenario "Assigning it to complete the claims establishment" (#19209) * deleted a flakey hang and added an expect for the url * Added a few more expects * small formating changes * removed no longer needed comment * removed unneccesarcy expect * Revert "laurenoelle/APPEALS-19871 initial files" * Hearing Admin selection changed to Hearings Management * aaron/APPEALS-28367 (#19210) * APPEALS-28367 Added Slack Notification upon job failure on priority_ep_sync_batch_process_job.rb. Updated RSPEC. * APPEALS-28367 Added slack alerts for job failures in populate end product sync queue job. Refactored error logging and sentry alerts in populate end product sync queue job & priority ep sync batch process job. Updated RSPEC. * APPEALS-28367 Added Slack Alert to BatchProcessRescueJob upon failure to reprocess. Updated RSPEC. * APPEALS-28367 Added more negative testing for slack alerts in populate_end_product_sync_queue_job.rb. * APPEALS-28367 Refactored batch_process.rb by adding private attr_accessors for counter instance variables. * APPEALS-28367 Removed extranneous blank line from end_product_establishment factory. * APPEALS-28367 Added Slack Alert negative testing to RSPEC for batch_process_rescue_job & priority_ep_sync_batch_process_job_spec. * APPEALS-28367 Fixed linting issue for ready_to_batch scope in priority_end_product_sync_queue.rb. * APPEALS-28367 Refactored RSPEC. * APPEALS-28367 Removed Instance variables from RSPECs. Updated ENV variables in test.rb * APPEALS-28367 Updated parameter name in no-op method in batch_process.rb to resolve code climate issue. Updated RSPEC to reflect this change. * APPEALS-28367 Added Reek statements to address various code climate alerts. * APPEALS-28367 Removed SLEEP DURATION Stubbing in caseflow_stuck_records to address code climate alert. * fixing flaky test (#19231) * fixing flaky test * removing commented code * fix flakey tests in login spec (#19233) * Revert "lthompson/APPEALS-26633" * APPEALS-28989 Added Ensure block that will always update last_synced_at date/time regardless of error to ensure that SyncReviewsJob does not immediately re-queue failing end product establishment and allows for other end product estaablishments to attempt sync with BGS first. Updated RSPEC to reflect this change. * Add jest tests for `CancelIntakeModal` (#19238) * added the code needed for the test to pass (#19243) * TYLERB/APPEALS-29085: Fix flakyness in the pre_docket_spec.rb file (#19247) * Added a few more expect statements to the predocket spec to attempt to reduce flakyness. * Changed the visit case details to the reload_case_details method. * Changed all of the visit appeal uuid/external id links to the case details page to use the reload_case_detail_page to reduce flakyness. * nkirby/APPEALS-28544-v2 (#19225) * condense process_batch examples * condense create_batch examples * condense find_records_to_batch examples * tag 21351 tests * remove pr tags * Appeals 28984 - fix code climate issues for feature/APPEALS-21351-merged (#19228) * init commit - testing code climate fix * removed method from initialize and add attt_reader * revert changes of initalizer but added attr_reader :file_number * removed @file_number and changed request_issue_1 * removed veteran_file_number and just added veteran * added veteran_file_number back and kept the vet * removed veteran,left file_number, n removed id * changes to error string and removed sleep comment * fixed too many lines, double quotes, and space * long lines * remove line to long pepsq line13 had to add lambda * replacedw/ doublequotes & moved for alphabet order * removed extra line * removed sleep comment * removed sleep comment from caseflowstuckrecordspec * removed sleep comment populate_end_prod_sync_qu * removed line to long and ( ) around methods * ignore line length warn * re-enable line length * removed un used code * disabled FeatureEnvy Smell * removed comment * Disabled InstanceVariableAssumption * Update batch_process_rescue_job.rb * APPEALS-28984 - uncommented claimant_participant_id & disabled FeatureEnvy for line 185 * moved comments * add missing comma * Add three phases to sync jobs * Switch to standard error * Remove old FTs * fixed linting on sync and added test for RedisMutex lock error (#19237) * fixed linting on sync and added test for RedisMutex lock error * added epe id to display in error message * fixed linting * rubocop long line fixes * fixed new line causing test failure * fixed new lines * fixed rubocop long lines * APPEALS-28960 Updated formatting of log message and content to include "#sync!". --------- Co-authored-by: TuckerRose <[email protected]> Co-authored-by: Jeffrey Aaron Willis <[email protected]> * Update MAC_M1.md * APPEALS-29860 Fixed Indentation linting issue on sync! method. (#19268) * Update log statement * Fix test * Better uniq * clear user session after each test (#19254) * added comment to makefile (#19305) * added comment to makefile * additional comment --------- Co-authored-by: Jonathan Tsang <[email protected]> * Remove coverage step from workflow for now * Add back in returns --------- Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: Matt Roth <[email protected]> Co-authored-by: breedbah <[email protected]> Co-authored-by: raymond-hughes <[email protected]> Co-authored-by: 631862 <[email protected]> Co-authored-by: Matthew Thornton <[email protected]> Co-authored-by: Ariana Konhilas <[email protected]> Co-authored-by: Lauren Berry <[email protected]> Co-authored-by: youfoundmanesh <[email protected]> Co-authored-by: jshields13 <[email protected]> Co-authored-by: breedbah <[email protected]> Co-authored-by: mchbidwell <[email protected]> Co-authored-by: HunJerBAH <[email protected]> Co-authored-by: AnandEdara <[email protected]> Co-authored-by: kristeja <[email protected]> Co-authored-by: kristeja <[email protected]> Co-authored-by: (Jeffrey) Aaron Willis <[email protected]> Co-authored-by: Craig Reese <[email protected]> Co-authored-by: Matthew Thornton <[email protected]> Co-authored-by: Clay Sheppard <[email protected]> Co-authored-by: Craig Reese <[email protected]> Co-authored-by: Jeff Marks <[email protected]> Co-authored-by: Jeffrey Aaron Willis <[email protected]> Co-authored-by: Jeremy Croteau <[email protected]> Co-authored-by: Eli Brown <[email protected]> Co-authored-by: Jeremy Croteau <[email protected]> Co-authored-by: Lauren Berry <[email protected]> Co-authored-by: Raymond Hughes <[email protected]> Co-authored-by: mikefinneran <[email protected]> Co-authored-by: sbashamoni <[email protected]> Co-authored-by: Prajwal Amatya <[email protected]> Co-authored-by: = <[email protected]> Co-authored-by: Brandon Lee Dorner <[email protected]> Co-authored-by: Sean Craig <[email protected]> Co-authored-by: Tyler Broyles <[email protected]> Co-authored-by: nkirby-va <[email protected]> Co-authored-by: Enrilo Ugalde <[email protected]> Co-authored-by: Will Love <[email protected]> Co-authored-by: TuckerRose <[email protected]> Co-authored-by: Jonathan Tsang <[email protected]>
- Loading branch information
41 people
authored
Sep 5, 2023
1 parent
5fdecdc
commit 378b044