Update DTO builder and Spec

[NoelleAd]

Resolves Jira Issue Title

Description

Please explain the changes you made here.

Acceptance Criteria

• Code compiles correctly

Testing Plan

1. Go to Jira Issue/Test Plan Link or list them below

• For feature branches merging into master: Was this deployed to UAT?

Backend

Database Changes

Only for Schema Changes

• Add typical timestamps (created_at, updated_at) for new tables
• Update column comments; include a "PII" prefix to indicate definite or potential PII data content
• Verify that migrate:rollback works as desired (change supported functions)
• Perform query profiling (eyeball Rails log, check bullet and fasterer output)
• For queries using raw sql was an explain plan run by System Team
• Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)

Integrations: Adding endpoints for external APIs

• Check that Appeals Consumer's external API code for the endpoint matches the code in the relevant integration repo
  • Request: Service name, method name, input field names
  • Response: Check expected data structure
  • Check that calls are wrapped in MetricService record block
• Check that all configuration is coming from ENV variables
  • Listed all new ENV variables in description
  • Worked with or notified System Team that new ENV variables need to be set
• Update Fakes
• For feature branches: Was this tested in Appeals Consumer UAT

Best practices

Code Documentation Updates

• Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

• RSpec
• Other

Code Climate

Your code does not add any new code climate offenses? If so why?

• No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

• Are performance metrics (e.g., response time, throughput) being tracked?
• Are key application components monitored (e.g., database, cache, queues)?
• Is there a system in place for setting up alerts based on performance thresholds?

Logging

• Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
• Are logs structured (e.g., using log tags) for easier querying and analysis?
• Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
• Is log retention and rotation configured correctly?
• Are logs being forwarded to a centralized logging system if needed?

Auditing

• Are user actions being logged for audit purposes?
• Are changes to critical data being tracked ?
• Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

• Are errors being caught and handled gracefully?
• Are appropriate error messages being displayed to users?
• Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
• Are unhandled exceptions being caught at the application level ?

Exception Handling

• Are custom exceptions defined and used where appropriate?
• Is exception handling consistent throughout the codebase?
• Are exceptions logged with relevant context and stack trace information?
• Are exceptions being grouped and categorized for easier analysis and resolution?

[github-actions]

Total Coverage: 100.00%

Coverage Report

File	Branches	Funcs	Lines	Uncovered Lines
./app/concerns
logger_mixin.rb	100%	100%	100%
./app/consumers
application_consumer.rb	100%	100%	100%
decision_review_created_consumer.rb	100%	100%	100%
decision_review_updated_consumer.rb	100%	100%	100%
person_updated_consumer.rb	100%	100%	100%
./app/controllers
application_controller.rb	100%	100%	100%
health_checks_controller.rb	100%	100%	100%
./app/controllers/api
application_controller.rb	100%	100%	100%
./app/controllers/api/v1
jobs_controller.rb	100%	100%	100%
./app/jobs
application_job.rb	100%	100%	100%
base_event_processing_job.rb	100%	100%	100%
decision_review_created_event_processing_job.rb	100%	100%	100%
decision_review_updated_event_processing_job.rb	100%	100%	100%
event_processing_rescue_job.rb	100%	100%	100%
heartbeat_job.rb	100%	100%	100%
person_updated_event_processing_job.rb	100%	100%	100%
./app/mappers
power_of_attorney_mapper.rb	100%	100%	100%
./app/models
application_record.rb	100%	100%	100%
event.rb	100%	100%	100%
event_audit.rb	100%	100%	100%
./app/models/builders
base_claimant_builder.rb	100%	100%	100%
base_decision_review_created_request_issue_collection_builder.rb	100%	100%	100%
base_decision_review_updated_request_issue_collection_builder.rb	100%	100%	100%
base_dto_builder.rb	100%	100%	100%
base_end_product_establishment_builder.rb	100%	100%	100%
base_request_issue_builder.rb	100%	100%	100%
base_request_issue_collection_builder.rb	100%	100%	100%
base_veteran_builder.rb	100%	100%	100%
./app/models/builders/decision_review_created
claim_review_builder.rb	100%	100%	100%
claimant_builder.rb	100%	100%	100%
dto_builder.rb	100%	100%	100%
end_product_establishment_builder.rb	100%	100%	100%
intake_builder.rb	100%	100%	100%
request_issue_builder.rb	100%	100%	100%
request_issue_collection_builder.rb	100%	100%	100%
veteran_builder.rb	100%	100%	100%
./app/models/builders/decision_review_updated
added_issue_collection_builder.rb	100%	100%	100%
claim_review_builder.rb	100%	100%	100%
dto_builder.rb	100%	100%	100%
eligible_to_ineligible_issue_collection_builder.rb	100%	100%	100%
end_product_establishment_builder.rb	100%	100%	100%
ineligible_to_eligible_issue_collection_builder.rb	100%	100%	100%
ineligible_to_ineligible_issue_collection_builder.rb	100%	100%	100%
removed_issue_collection_builder.rb	100%	100%	100%
request_issue_builder.rb	100%	100%	100%
updated_issue_collection_builder.rb	100%	100%	100%
withdrawn_issue_collection_builder.rb	100%	100%	100%
./app/models/builders/person_updated
dto_builder.rb	100%	100%	100%
./app/models/concerns
message_payload_validator.rb	100%	100%	100%
./app/models/concerns/decision_review
model_builder_helper.rb	100%	100%	100%
./app/models/events
decision_review_created_event.rb	100%	100%	100%
decision_review_updated_event.rb	100%	100%	100%
person_updated_event.rb	100%	100%	100%
./app/models/virtual
base_claimant.rb	100%	100%	100%
base_person.rb	100%	100%	100%
base_request_issue.rb	100%	100%	100%
base_veteran.rb	100%	100%	100%
./app/models/virtual/decision_review_created
claim_review.rb	100%	100%	100%
claimant.rb	100%	100%	100%
end_product_establishment.rb	100%	100%	100%
intake.rb	100%	100%	100%
request_issue.rb	100%	100%	100%
veteran.rb	100%	100%	100%
./app/models/virtual/decision_review_updated
claim_review.rb	100%	100%	100%
end_product_establishment.rb	100%	100%	100%
request_issue.rb	100%	100%	100%
./app/models/virtual/person_updated
person.rb	100%	100%	100%
./app/models/virtual/transformers
decision_review_created.rb	100%	100%	100%
decision_review_updated.rb	100%	100%	100%
person_updated.rb	100%	100%	100%
./app/services
avro_deserializer_service.rb	100%	100%	100%
avro_logger_service.rb	100%	100%	100%
avro_service.rb	100%	100%	100%
logger_service.rb	100%	100%	100%
metrics_service.rb	100%	100%	100%
slack_service.rb	100%	100%	100%
./app/services/external_api
caseflow_service.rb	100%	100%	100%
./config
application.rb	100%	100%	100%
boot.rb	100%	100%	100%
environment.rb	100%	100%	100%
routes.rb	100%	100%	100%
./config/environments
development.rb	100%	100%	100%
./lib
pii_sanitizer.rb	100%	100%	100%
./lib/appeals_consumer
error.rb	100%	100%	100%
./lib/kafka_message_generators
base.rb	100%	100%	100%
decision_review_events.rb	100%	100%	100%

[dcoleman21]

This all looks good.