Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript to 5.4 #407

Open
dylanpyle opened this issue May 13, 2024 · 3 comments
Open

Upgrade typescript to 5.4 #407

dylanpyle opened this issue May 13, 2024 · 3 comments

Comments

@dylanpyle
Copy link
Contributor

(PR coming shortly)

Looks like this dependency comes from @ts-morph/bootstrap; bumping that version to 0.23+ should now use TypeScript 5.4.

This will definitely break some builds, as 5.4 is stricter about a few things (e.g. type imports conflicting with local values), but allows usage of new features like NoInfer.

dylanpyle added a commit to dylanpyle/dnt that referenced this issue May 13, 2024
@dylanpyle
Copy link
Contributor Author

dylanpyle commented May 13, 2024

Well - I tried to make this change but I'm having some issues getting it to work - will follow up if I get that resolved:

  • Branch is here
  • Hitting this error when pulling from this branch (via jsdelivr):
error: Relative import path "@std/fs/empty_dir" not prefixed with / or ./ or ../ and not in import map from "https://cdn.jsdelivr.net/gh/dylanpyle/dnt/mod.ts"
    at https://cdn.jsdelivr.net/gh/dylanpyle/dnt/mod.ts:30:26

@dsherret
Copy link
Member

@dylanpyle could you open a pr even if it might not be working? (It won't work via jsdelivr because it's using an import map internally. In Deno we need to improve the situation of using a jsr dep locally when it uses an import map.)

@dylanpyle
Copy link
Contributor Author

@dsherret sure thing - #408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants