feat: add rules_of_hooks rule #1346
Merged
+466
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Nov 29, 2024
Comment on lines
+65
to
+73
| function Component() { | ||
| const [count, setCount] = useState(0); | ||
| // ... | ||
| } | ||
|
|
||
| function useCustomHook() { | ||
| const [count, setCount] = useState(0); | ||
| // ... | ||
| } |
There was a problem hiding this comment.
Could you update this one to show all "bad" examples written in a correct form?
There was a problem hiding this comment.
These are the only correct ones for all bad examples.
Comment on lines
+274
to
+277
| if let Some(ch) = name.chars().next() { | ||
| return ch.is_uppercase(); | ||
| } |
There was a problem hiding this comment.
Where is this hit? Could you add a small unit test for this function?
There was a problem hiding this comment.
This is hit in pretty much all bad variants. It tests if the enclosing function is a component.
Co-authored-by: Bartek Iwańczuk <[email protected]>
Co-authored-by: Bartek Iwańczuk <[email protected]>
marvinhagemeister
force-pushed
the
rules-of-hooks
branch
from
170903f to
f34cead
Compare
bartlomieju
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
rules-of-hookseslint rule, see https://react.dev/reference/rules/rules-of-hooks . It ensures that hooks are only used inside components and that they are called unconditionally.