feat: add jsx-key rule (#1355)

* feat: add jsx-key rule

* fix: clippy

* fix: update schemas

* message

Co-authored-by: Bartek Iwańczuk <[email protected]>

* message

Co-authored-by: Bartek Iwańczuk <[email protected]>

* message

Co-authored-by: Bartek Iwańczuk <[email protected]>

* fixup

* chore: simplify indentation

---------

Co-authored-by: Bartek Iwańczuk <[email protected]>

docs/rules/jsx_key.md

@@ -0,0 +1,20 @@
+Ensure the `key` attribute is present when passing iterables into JSX. It allows
+frameworks to optimize checking the order of elements.
+
+### Invalid:
+
+```tsx
+const foo = [<div>foo</div>];
+const foo = [<>foo</>];
+[1, 2, 3].map(() => <div />);
+Array.from([1, 2, 3], () => <div />);
+```
+
+### Valid:
+
+```tsx
+const foo = [<div key="a">foo</div>];
+const foo = [<Fragment key="b">foo</Fragment>];
+[1, 2, 3].map((x) => <div key={x} />);
+Array.from([1, 2, 3], (x) => <div key={x} />);
+```

schemas/rules.v1.json

@@ -22,6 +22,7 @@
     "guard-for-in",
     "jsx-boolean-value",
     "jsx-curly-braces",
+    "jsx-key",
     "jsx-no-children-prop",
     "jsx-no-danger-with-children",
     "jsx-no-duplicate-props",

src/rules.rs

@@ -29,6 +29,7 @@ pub mod getter_return;
 pub mod guard_for_in;
 pub mod jsx_boolean_value;
 pub mod jsx_curly_braces;
+pub mod jsx_key;
 pub mod jsx_no_children_prop;
 pub mod jsx_no_danger_with_children;
 pub mod jsx_no_duplicate_props;
@@ -270,6 +271,7 @@ fn get_all_rules_raw() -> Vec<Box<dyn LintRule>> {
     Box::new(guard_for_in::GuardForIn),
     Box::new(jsx_boolean_value::JSXBooleanValue),
     Box::new(jsx_curly_braces::JSXCurlyBraces),
+    Box::new(jsx_key::JSXKey),
     Box::new(jsx_no_children_prop::JSXNoChildrenProp),
     Box::new(jsx_no_danger_with_children::JSXNoDangerWithChildren),
     Box::new(jsx_no_duplicate_props::JSXNoDuplicateProps),