Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Manager, Clicking Files Has No Effect #50

Open
wbraswell opened this issue Jan 7, 2015 · 3 comments
Open

File Manager, Clicking Files Has No Effect #50

wbraswell opened this issue Jan 7, 2015 · 3 comments

Comments

@wbraswell
Copy link

When I invoke root/admin/filemanager/view.tt I should be able to click on each file (either image or non-image) and have something happen. According to the code, CKEditor should be launched with some unknown action, which doesn't work.

[% file.filename %]

BECOMES

nmakers_home.tt

Which gives a Javascript syntax error because callFunction has a missing first argument and goes straight to a comma.

If we can't have CKEditor launched for whatever reason, we at least need to make it so that there are valid links to download the files. As it is now, we can only look at a list of files, clicking on the files does nothing!

@wbraswell
Copy link
Author

Here's my work-around code from view.tt:

    [%- IF file.image %]
<a href="/static/[% path.join( '/' ) %]/[% file.filename %]"><img src="/static/[% path.join( '/' ) IF path %]/[% file.filename %]" class="filemanager-img" alt="[% file.filename %]" title="Click to select this image"></a>
<br><a href="/static/[% path.join( '/' ) %]/[% file.filename %]">[% file.filename %]</a>
    [%- ELSE %]
<a href="/static/[% path.join( '/' ) %]/[% file.filename %]"><img src="/static/images/icons/file.png" class="filemanager-img" alt="[% file.filename %]" title="Click to select file"></a>
<br><a href="/static/[% path.join( '/' ) %]/[% file.filename %]">[% file.filename %]</a>
    [%- END %]

@denny
Copy link
Owner

denny commented Mar 1, 2016

The filepicker window is primarily designed to be launched from CKEditor, rather than vice versa. I thought it might be useful to also make it directly visible in the admin area, but in practice it's mostly just caused confusion. I may remove the link from the admin menus until a better UI can be written...

@wbraswell
Copy link
Author

Why can't we just have file download links?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants