Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-bug - remove more sensitive data from the logs #37901

Merged
merged 21 commits into from
Jan 9, 2025
Merged

dev-bug - remove more sensitive data from the logs #37901

merged 21 commits into from
Jan 9, 2025

Conversation

MLainer1
Copy link
Contributor

@MLainer1 MLainer1 commented Jan 1, 2025

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Base/Scripts/CommonServerPython
   CommonServerPython.py471377983%174–177, 188, 190, 427, 469, 565, 591–595, 620, 635, 777–778, 787, 828–829, 847, 877–881, 885–887, 929, 1016–1024, 1068–1073, 1107–1109, 1239–1243, 1246–1247, 1249–1251, 1265–1267, 1269, 1335, 1348, 1361, 1369–1371, 1373, 1386, 1394, 1496–1497, 1552, 1574–1575, 1578, 1584, 1586, 1588, 1695, 1741, 1815–1816, 1820–1821, 1860–1861, 1875–1880, 1882, 1950, 2033, 2035, 2055, 2085, 2089, 2131, 2310, 2334, 2373–2374, 2454–2455, 2457, 2470–2477, 2479, 2556–2558, 2572, 2585, 2616, 2622–2626, 2628–2630, 2632, 2636–2637, 2639, 2652–2658, 2662, 2666–2668, 2674–2675, 2687, 2715, 2718, 2723, 2743, 2749, 2751, 2753, 2773, 2776, 2788, 2834–2842, 2844, 2903, 2925, 2945, 3003, 3015–3016, 3128, 3130, 3332, 3342, 3348, 3357, 3363, 3377, 3433, 3442, 3445, 3448, 3451, 3454, 3457, 3466, 3468, 3473–3474, 3505–3510, 3513, 3564–3565, 3568, 3734–3735, 3738, 3845, 3848, 4099, 4102, 4105, 4108, 4113, 4122, 4148, 4154, 4157, 4163, 4166, 4169, 4172, 4175, 4184, 4186, 4302–4303, 4327, 4329, 4348, 4351, 4354, 4422, 4443, 4445, 4607, 4625, 4637, 4667, 4670, 4676, 4679, 4682, 4691, 4693, 4893–4894, 4913, 4916, 4919, 4922, 4928, 4990, 4992, 5017, 5032–5048, 5051, 5055–5056, 5058–5059, 5061–5062, 5064–5065, 5067–5068, 5070–5071, 5073–5074, 5076–5077, 5079–5080, 5082–5083, 5085–5086, 5088–5089, 5091–5092, 5094, 5096–5097, 5099–5102, 5104–5106, 5108, 5110, 5114, 5190, 5230, 5236, 5238, 5248, 5286, 5291–5292, 5297, 5301–5302, 5304, 5386, 5392, 5485, 5506, 5509–5514, 5522–5528, 5530–5531, 5576, 5589, 5685–5688, 5693, 5696, 5699, 5733, 5736, 5780, 5782, 5784, 5879, 5930, 6012, 6024, 6042, 6082–6083, 6087, 6089, 6123, 6127, 6129, 6131, 6133, 6179, 6183, 6282–6285, 6287, 6300, 6319, 6329, 6335, 6344–6346, 6349–6352, 6367, 6409, 6438, 6441, 6500–6510, 6513, 6523–6524, 6526–6527, 6529–6530, 6535, 6539–6540, 6542, 6579–6582, 6585–6589, 6593, 6601, 6607, 6635, 6664, 6670–6671, 6722, 6742–6743, 6745, 6785–6786, 6793, 6798, 6804, 6817–6818, 6820, 7091–7093, 7112, 7125, 7137, 7165, 7325, 7340, 7405, 7435, 7477–7478, 7490, 7505–7506, 7508–7509, 7511–7512, 7514–7515, 7517–7520, 7522, 7524–7525, 7527, 7606–7607, 7619, 7663–7666, 7668, 7675–7676, 7836, 7891, 7927, 7947, 7949, 8050, 8210–8213, 8215–8217, 8276, 8295–8296, 8308, 8324, 8345–8346, 8348, 8365, 8452, 8466, 8469–8472, 8475, 8478, 8500–8503, 8600, 8619–8620, 8745, 8762–8764, 8800–8802, 8812–8813, 8831, 8863, 8919, 8923–8924, 8938, 8941, 8954–8956, 8959, 9031, 9201–9202, 9282–9283, 9327–9328, 9330, 9333, 9344, 9350–9353, 9355, 9357, 9359–9360, 9476, 9601, 9615, 9618, 9822, 9831, 9897–9898, 9902, 9963–9966, 9968, 9990, 10002, 10098, 10134–10135, 10148, 10161–10166, 10182–10183, 10191–10192, 10205, 10213–10214, 10231–10232, 10246, 10256, 10272, 10283, 10291–10293, 10295, 10321, 10336, 10347, 10365–10366, 10369, 10387, 10390, 10405, 10419, 10425, 10440, 10457, 10469–10477, 10480–10481, 10483, 10498–10500, 10511, 10514, 10603, 10629, 10636, 10680, 10706–10707, 10750, 10752–10754, 10756, 10831, 10840, 10961, 11025, 11029–11030, 11121–11126, 11222–11225, 11316–11318, 11344, 11378, 11428–11429, 11434–11435, 11452, 11538–11540, 11559, 11771, 11888, 11912, 11935, 11960, 11967–11973, 11975, 11977, 12128, 12179–12180, 12182–12189, 12194–12196, 12198, 12200, 12315–12316, 12335, 12373–12374, 12378, 12407–12415, 12417–12418, 12439, 12442, 12444–12445, 12447, 12449, 12451, 12453–12456, 12458, 12460–12461, 12465–12467, 12500, 12564–12565, 12567, 12575, 12584, 12588, 12590–12592, 12595–12596, 12599–12602, 12605, 12608, 12611–12618, 12620, 12631–12634, 12637, 12639–12643, 12645–12647, 12649
TOTAL471377983% 

Tests Skipped Failures Errors Time
5936 100 💤 0 ❌ 0 🔥 4m 29s ⏱️

@MLainer1 MLainer1 requested a review from dantavori January 5, 2025 09:35
@MLainer1 MLainer1 marked this pull request as ready for review January 5, 2025 09:35
dantavori
dantavori approved these changes Jan 5, 2025
View reviewed changes
Packs/Base/ReleaseNotes/1_39_8.md Outdated

##### CommonServerPython

- Added more filtering words in the censor_request_logs function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Added more filtering words in the censor_request_logs function
- Logging improvements.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.39.9.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.39.10.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.39.11.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.39.12.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@MLainer1 MLainer1 added the ForceMerge Forcing the merge of the PR despite the build status label Jan 9, 2025
@MLainer1
Copy link
Contributor Author

MLainer1 commented Jan 9, 2025

This PR needs a FM due to errors in pylint that will be fixed in:
#38042
#38043
#38048
#38053
#38055
#38058
#38059

Adding a screenshot of locally running pre-commit on the PR
image

@dantavori dantavori merged commit d13e477 into master Jan 9, 2025
19 of 20 checks passed
@dantavori dantavori deleted the dev_bug_remove_sensitive_data_from_logs branch January 9, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantavori dantavori dantavori approved these changes

Assignees
No one assigned
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MLainer1 @content-bot @CLAassistant @dantavori