From 2289cd5ebf767dd33b40ef79315910bf14d02759 Mon Sep 17 00:00:00 2001 From: Karina Fishman <147307864+karinafishman@users.noreply.github.com> Date: Tue, 9 Jul 2024 20:04:03 +0300 Subject: [PATCH] Fix for XSOAR automation insights dashboard (#35292) * added the relevant script to the metrics * added rn * fix * pre commit * fix * updated RN after revert * Update Packs/CommonDashboards/ReleaseNotes/1_7_4.md Co-authored-by: Sasha Sokolovich <88268646+ssokolovich@users.noreply.github.com> --------- Co-authored-by: Sasha Sokolovich <88268646+ssokolovich@users.noreply.github.com> --- .../Dashboards/XSOAR_Automation_Insights.json | 5 ++++- Packs/CommonDashboards/ReleaseNotes/1_7_4.md | 12 ++++++++++++ .../Scripts/AdoptionMetrics/AdoptionMetrics.py | 1 + Packs/CommonDashboards/pack_metadata.json | 2 +- 4 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 Packs/CommonDashboards/ReleaseNotes/1_7_4.md diff --git a/Packs/CommonDashboards/Dashboards/XSOAR_Automation_Insights.json b/Packs/CommonDashboards/Dashboards/XSOAR_Automation_Insights.json index e8120bf8d8ff..bc5a5c28f0b6 100644 --- a/Packs/CommonDashboards/Dashboards/XSOAR_Automation_Insights.json +++ b/Packs/CommonDashboards/Dashboards/XSOAR_Automation_Insights.json @@ -834,6 +834,9 @@ }, "type": "above" }, + "keys": [ + "sum|droppedCount" + ], "valuesFormat": "abbreviated" }, "category": "" @@ -972,7 +975,7 @@ "prevName": "Use Case Adoption Coverage", "dataType": "scripts", "widgetType": "text", - "query": "UseCaseAdoptionMetrics", + "query": "AdoptionMetrics", "isPredefined": false, "dateRange": { "fromDate": "0001-01-01T00:00:00Z", diff --git a/Packs/CommonDashboards/ReleaseNotes/1_7_4.md b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md new file mode 100644 index 000000000000..cdb139608d4f --- /dev/null +++ b/Packs/CommonDashboards/ReleaseNotes/1_7_4.md @@ -0,0 +1,12 @@ + +#### Dashboards + +##### XSOAR Automation Insights + +- Updated the "Adoption Metrics" widgets' script. + +#### Scripts + +##### AdoptionMetrics + +- Fixed the return argument. diff --git a/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py b/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py index 4de25ebdffdf..e42f9d22564f 100644 --- a/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py +++ b/Packs/CommonDashboards/Scripts/AdoptionMetrics/AdoptionMetrics.py @@ -108,6 +108,7 @@ def main(): t.append({'Use Case Adoption & Coverage': use_case, 'Status': '❌'}) table = tableToMarkdown(name='Use Case Coverage', t=t, headers=headers) + return_results(table) return table diff --git a/Packs/CommonDashboards/pack_metadata.json b/Packs/CommonDashboards/pack_metadata.json index 3561716d2307..843a63ba6c55 100644 --- a/Packs/CommonDashboards/pack_metadata.json +++ b/Packs/CommonDashboards/pack_metadata.json @@ -2,7 +2,7 @@ "name": "Common Dashboards", "description": "Frequently used dashboards pack.", "support": "xsoar", - "currentVersion": "1.7.3", + "currentVersion": "1.7.4", "author": "Cortex XSOAR", "url": "https://www.paloaltonetworks.com/cortex", "email": "",