-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
self contact, and some other contacts, erroneously marked as a bot #6357
Comments
That's kinda crazy. It's not the case for me Here is the relevant code:
Is your account marked as bot somehow?? |
we got reports here and there, that chats are marked accidentally as "Bot", not only "Saved Messages". however, no way yet to reproduce it. wondering if it recovers or if the chats stay as "Bot" maybe there is some read-receipt, status-update or sync-message that sets "auto-submitted" or so somehow wrong - or the condition for setting is_bot in receive_imf is wrong |
|
But this will only solve it for "Saved messages" and not conversations:
|
Seems to be a core issue. Feel free to move it there, moreover if there are cases reported for other platforms |
Delta Chat always adds protected headers to the inner encrypted or signed message, so if a protected header is only present in the outer part, it should be ignored because it's probably added by the server or somebody else. The exception is Subject because there are known cases when it's only present in the outer message part, e.g. an encrypted unsigned Thunderbird message. Also handle "Auto-Submitted" and "Autocrypt-Setup-Message" as protected headers on the receiver side, this was apparently forgotten. This may fix #6357 where Saved Messages (i.e. `ContactId::SELF`) and some contacts are unexpectedly marked as bots which can happen if e.g. the server adds "Auto-Submitted: auto-generated" to messages for some reason. Maybe sounds unlikely, but let's try.
Delta Chat always adds protected headers to the inner encrypted or signed message, so if a protected header is only present in the outer part, it should be ignored because it's probably added by the server or somebody else. The exception is Subject because there are known cases when it's only present in the outer message part, e.g. an encrypted unsigned Thunderbird message. Also handle "Auto-Submitted" and "Autocrypt-Setup-Message" as protected headers on the receiver side, this was apparently forgotten. This may fix #6357 where Saved Messages (i.e. `ContactId::SELF`) and some contacts are unexpectedly marked as bots which can happen if e.g. the server adds "Auto-Submitted: auto-generated" to messages for some reason. Maybe sounds unlikely, but let's try.
Delta Chat always adds protected headers to the inner encrypted or signed message, so if a protected header is only present in the outer part, it should be ignored because it's probably added by the server or somebody else. The exception is Subject because there are known cases when it's only present in the outer message part, e.g. an encrypted unsigned Thunderbird message. Also handle "Auto-Submitted" and "Autocrypt-Setup-Message" as protected headers on the receiver side, this was apparently forgotten. This may fix #6357 where Saved Messages (i.e. `ContactId::SELF`) and some contacts are unexpectedly marked as bots which can happen if e.g. the server adds "Auto-Submitted: auto-generated" to messages for some reason. Maybe sounds unlikely, but let's try.
@adbenitez and me were marked as being a bots to each other after both enabling location streaming in our one-to-one chat. maybe there is sth. wrong with the auto-generated location messages |
Indeed, this is the true reason of the bug. Location-only, sync and webxdc status update messages add SystemMessage::LocationOnly
| SystemMessage::MultiDeviceSync
| SystemMessage::WebxdcStatusUpdate => {
// This should prevent automatic replies,
// such as non-delivery reports.
//
// See <https://tools.ietf.org/html/rfc3834>
//
// Adding this header without encryption leaks some
// information about the message contents, but it can
// already be easily guessed from message timing and size.
headers.push(Header::new(
"Auto-Submitted".to_string(),
"auto-generated".to_string(),
)); But only webxdc status updates are excluded from the |
"Saved Messages" are called a bot.
Screenshot
macOS 15.2
DC-Desktop 1.50
The text was updated successfully, but these errors were encountered: