Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support for ECDSA Keys because EDC requires them #21

Open
kettenbach-it opened this issue Oct 26, 2022 · 1 comment
Open

[Enhancement] Support for ECDSA Keys because EDC requires them #21

kettenbach-it opened this issue Oct 26, 2022 · 1 comment
Labels
Type: Enhancement Feature enhancement request

Comments

@kettenbach-it
Copy link
Contributor

kettenbach-it commented Oct 26, 2022 •
edited
Loading

Motivation / Problem

The Eclipse Dataspace Connector (EDC) requires the users to use EC signatures instead of RSA.
The self-description-signer does not support EC keys:

❯ node index.js
📝 Loaded ./config/self-description.json
📈 Hashed canonized SD 8fc77f3ec2a1add9803dd55cc8d833c916521d2310f7e93e8310c5f21920e07c
TypeError: Invalid key for this operation, its asymmetricKeyType must be rsa or rsa-pss
    at keyForCrypto (self-description-signer/node_modules/jose/dist/node/cjs/runtime/node_key.js:53:23)
    at sign (self-description-signer/node_modules/jose/dist/node/cjs/runtime/sign.js:23:91)
    at FlattenedSign.sign (self-description-signer/node_modules/jose/dist/node/cjs/jws/flattened/sign.js:68:55)
    at CompactSign.sign (self-description-signer/node_modules/jose/dist/node/cjs/jws/compact/sign.js:14:43)
    at sign (self-description-signer/index.js:48:14)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async createProof (self-description-signer/index.js:63:10)
    at async main (self-description-signer/index.js:173:19)

Therefore I can't use the web:dids for EDC.

Solution

self-description-signer should support EC keys.

Alternatives

None

Additional context

Pull request for logging key signing errors: #22
@kettenbach-it kettenbach-it added the Type: Enhancement Feature enhancement request label Oct 26, 2022
kettenbach-it added a commit to kettenbach-it/self-description-signer that referenced this issue Oct 26, 2022
@kettenbach-it
Added exception handling and extra logging for signing of keys.
4077f86 
See deltaDAO#21
@kettenbach-it kettenbach-it mentioned this issue Oct 26, 2022
Merged
@kettenbach-it kettenbach-it changed the title [Enhancement] Support for ECDSA Keys because EDC required them [Enhancement] Support for ECDSA Keys because EDC requires them Oct 26, 2022
oceanByte pushed a commit that referenced this issue Oct 26, 2022
@kettenbach-it
Added exception handling and extra logging for signing of keys. (#22)
19688b2 
See #21
@kettenbach-it kettenbach-it mentioned this issue Nov 3, 2022
Open
@kettenbach-it
Copy link
Contributor Author

I tried to play around with jose a little to get ECDSA to work: #25

Signing works, but not local verification.
I'm not an export in node and not in jose either....

In the end, it's pointless anyway, because the server part of the whole thing has to be able to do ECDSA: https://github.com/deltaDAO/self-description-signing-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Feature enhancement request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kettenbach-it