Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

training script improvements #62

Closed
7 tasks done
jettjaniak opened this issue Mar 18, 2024 · 0 comments · Fixed by #31
Closed
7 tasks done

training script improvements #62

jettjaniak opened this issue Mar 18, 2024 · 0 comments · Fixed by #31
Assignees
Labels
feature New feature or request train

Comments

@jettjaniak
Copy link
Contributor

jettjaniak commented Mar 18, 2024

after we merge #31

  • running scripts/run_training.py w/o arguments yields obscure errors instead of help message
  • script is not informing the user what's going on - default log level is too low
  • setting log level is too complex, --verbose/-v flag should be sufficient
  • --help should not list hyperparameters of all supported models
  • llama should be llama2
  • run name should include config name
  • upload the model including checkpoints to HF
@jettjaniak jettjaniak added feature New feature or request train labels Mar 18, 2024
@jaidhyani jaidhyani linked a pull request Mar 19, 2024 that will close this issue
@jaidhyani jaidhyani self-assigned this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request train
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants