You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking across various projects using dkms (bbswitch, nvidia driver, openzfs and a bunch of others). The vast majority of them copy/paste the default (in-dkms) make/clean commands:
make -C $kernel_source_dir M=$dkms_tree/$module/$module_version/build
make -C $kernel_source_dir M=$dkms_tree/$module/$module_version/build clean"
That has a few interesting side effects - both kernel_source_dir (aka the linux path) and $dkms_tree are hard-coded in their config.
Glancing at the more complex modules (nvidia, openzfs) - they are glorified wrappers allowing behaviour changes (via funky indirection).
Off the top of my head, to handle these we could introduce a variable which gets added to the make command above. Say BUILD_FLAGS or BUILD_DEFINES (must include only -D...) or alike. As always the dkms.conf file will have the default, which can be altered by users with the existing conf.d override mechanism.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Looking across various projects using dkms (bbswitch, nvidia driver, openzfs and a bunch of others). The vast majority of them copy/paste the default (in-dkms) make/clean commands:
That has a few interesting side effects - both
kernel_source_dir
(aka the linux path) and$dkms_tree
are hard-coded in their config.Glancing at the more complex modules (nvidia, openzfs) - they are glorified wrappers allowing behaviour changes (via funky indirection).
Off the top of my head, to handle these we could introduce a variable which gets added to the make command above. Say
BUILD_FLAGS
orBUILD_DEFINES
(must include only-D...
) or alike. As always thedkms.conf
file will have the default, which can be altered by users with the existingconf.d
override mechanism.@scaronni @xuzhen any preferences?
@hadogenes considering your experience with openzfs what your take?
0 votes ·
Beta Was this translation helpful? Give feedback.
All reactions