Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature enhancement - synciqpolicy module #141

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Kritika-Bhateja-03
Copy link
Collaborator

@Kritika-Bhateja-03 Kritika-Bhateja-03 commented Dec 8, 2024

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@Kritika-Bhateja-03
Copy link
Collaborator Author

image
UT coverage

attributes:
check_mode:
description:
- Runs task to validate without performing action on the target machine.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Runs task to validate without performing action on the target machine.
- Can run in check_mode and return changed status prediction without modifying target, if not supported the action will be skipped.

support: full
diff_mode:
description:
- Runs the task to report the changes made or to be made.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Runs the task to report the changes made or to be made.
- Will return details on what has changed (or possibly needs changing in check_mode), when in diff mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants