diff --git a/CHANGELOG.md b/CHANGELOG.md index 49732f6..312e430 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [2.3.2]() - 2021-09-16 + +### Fixed +- Fixed issue with -SetTrapDestination parameter on New-OMEDiscovery ([Issue #4](https://github.com/dell/OpenManage-PowerShell-Modules/issues/4)) + ## [2.3.1]() - 2021-09-14 ### Added - Migrated scripts from https://github.com/dell/OpenManage-Enterprise/tree/master/PowerShell diff --git a/DellOpenManage/DellOpenManage.psd1 b/DellOpenManage/DellOpenManage.psd1 index c30e07c..24170c9 100644 --- a/DellOpenManage/DellOpenManage.psd1 +++ b/DellOpenManage/DellOpenManage.psd1 @@ -3,7 +3,7 @@ # # Generated by: Trevor Squillario # -# Generated on: 9/14/2021 +# Generated on: 9/16/2021 # @{ @@ -12,7 +12,7 @@ RootModule = 'DellOpenManage.psm1' # Version number of this module. -ModuleVersion = '2.3.1' +ModuleVersion = '2.3.2' # Supported PSEditions # CompatiblePSEditions = @() diff --git a/DellOpenManage/Public/OME/New-OMEDiscovery.ps1 b/DellOpenManage/Public/OME/New-OMEDiscovery.ps1 index a70cae6..612b040 100644 --- a/DellOpenManage/Public/OME/New-OMEDiscovery.ps1 +++ b/DellOpenManage/Public/OME/New-OMEDiscovery.ps1 @@ -69,10 +69,14 @@ function Get-DiscoverDevicePayload($Name, $HostList, $DeviceType, $DiscoveryUser } else { $DiscoveryConfigPayload.DiscoveryStatusEmailRecipient.PSObject.Properties.Remove("DiscoveryConfigTargets") } - $DiscoveryConfigPayload.TrapDestination = $SetTrapDestination + if ($SetTrapDestination) { + $DiscoveryConfigPayload.TrapDestination = $true + } # Add version check for UseAllProfiles if ($SessionAuth.Version -ge [System.Version]"3.7.0") { - $DiscoveryConfigPayload | Add-Member -NotePropertyName UseAllProfiles -NotePropertyValue $UseAllProtocols + if ($UseAllProtocols) { + $DiscoveryConfigPayload | Add-Member -NotePropertyName UseAllProfiles -NotePropertyValue $true + } } $DiscoveryConfigPayload.DiscoveryConfigModels[0].PSObject.Properties.Remove("DiscoveryConfigTargets") $DiscoveryConfigPayload.DiscoveryConfigModels[0]| Add-Member -MemberType NoteProperty -Name 'DiscoveryConfigTargets' -Value @() diff --git a/Documentation/Functions/Edit-OMESupportAssistGroup.md b/Documentation/Functions/Edit-OMESupportAssistGroup.md index 88ee507..c4ab8b4 100644 --- a/Documentation/Functions/Edit-OMESupportAssistGroup.md +++ b/Documentation/Functions/Edit-OMESupportAssistGroup.md @@ -47,21 +47,21 @@ Edit Support Assist group from json stored in variable ### EXAMPLE 3 ``` -Get-OMEGroup "Test Group 01" | Edit-OMEGroup -EditGroup $(Get-Content "C:\Temp\Group.json" -Raw) +Get-OMEGroup "Test Group 01" | Edit-OMESupportAssistGroup -EditGroup $(Get-Content "C:\Temp\Group.json" -Raw) ``` Edit Support Assist group from json stored in file ### EXAMPLE 4 ``` -Get-OMEGroup "Test Group 01" | Edit-OMEGroup -Devices $("PowerEdge R640" | Get-OMEDevice -FilterBy "Model") +Get-OMEGroup "Test Group 01" | Edit-OMESupportAssistGroup -Devices $("PowerEdge R640" | Get-OMEDevice -FilterBy "Model") ``` Add devices to group ### EXAMPLE 5 ``` -Get-OMEGroup "Test Group 01" | Edit-OMEGroup -Mode "Remove" -Devices $("PowerEdge R640" | Get-OMEDevice -FilterBy "Model") +Get-OMEGroup "Test Group 01" | Edit-OMESupportAssistGroup -Mode "Remove" -Devices $("PowerEdge R640" | Get-OMEDevice -FilterBy "Model") ``` Remove devices from group diff --git a/Documentation/Functions/Get-OMEAlertDefinition.md b/Documentation/Functions/Get-OMEAlertDefinition.md index 80ccbac..d761344 100644 --- a/Documentation/Functions/Get-OMEAlertDefinition.md +++ b/Documentation/Functions/Get-OMEAlertDefinition.md @@ -24,11 +24,9 @@ Returns all devices if no input received. ### EXAMPLE 1 ``` -Get-OMEDevice -Value 12016 +Get-OMEAlertDefinition ``` -Get device by Id - ## PARAMETERS ### CommonParameters diff --git a/Documentation/Functions/Get-OMEWarranty.md b/Documentation/Functions/Get-OMEWarranty.md index ec0fbdb..fb9ad1a 100644 --- a/Documentation/Functions/Get-OMEWarranty.md +++ b/Documentation/Functions/Get-OMEWarranty.md @@ -23,17 +23,10 @@ Get-OMEWarranty [] ### EXAMPLE 1 ``` -Get-OMEUser | Format-Table +Get-OMEWarranty | Format-Table ``` -List all users - -### EXAMPLE 2 -``` -"admin" | Get-OMEUser -``` - -Get user by name +List all warranty details ## PARAMETERS diff --git a/Documentation/Functions/Invoke-OMEMcmGroupAddMember.md b/Documentation/Functions/Invoke-OMEMcmGroupAddMember.md index 7102d81..32cf974 100644 --- a/Documentation/Functions/Invoke-OMEMcmGroupAddMember.md +++ b/Documentation/Functions/Invoke-OMEMcmGroupAddMember.md @@ -17,7 +17,7 @@ Invoke-OMEMcmGroupAddMember [-Wait] [[-WaitTime] ] [] ``` ## DESCRIPTION -This script uses the OME REST API to create mcm group, find memebers and add the members to the group. +This script uses the OME REST API to add all available chassis to the MCM Group ## EXAMPLES diff --git a/Documentation/Functions/Invoke-OMEMcmGroupAssignBackupLead.md b/Documentation/Functions/Invoke-OMEMcmGroupAssignBackupLead.md index c759cc1..a395a16 100644 --- a/Documentation/Functions/Invoke-OMEMcmGroupAssignBackupLead.md +++ b/Documentation/Functions/Invoke-OMEMcmGroupAssignBackupLead.md @@ -17,7 +17,7 @@ Invoke-OMEMcmGroupAssignBackupLead [[-ServiceTag] ] [-Wait] [[-WaitTime] ``` ## DESCRIPTION -This script uses the OME REST API to create mcm group, find memebers and add the members to the group. +This script uses the OME REST API to add a backup lead chassis ## EXAMPLES @@ -26,6 +26,15 @@ This script uses the OME REST API to create mcm group, find memebers and add the Invoke-OMEMcmGroupAssignBackupLead -Wait ``` +Assign backup lead to random chassis + +### EXAMPLE 2 +``` +Invoke-OMEMcmGroupAssignBackupLead -ServiceTag "XYZ1234" -Wait +``` + +Assign backup lead to specific chassis + ## PARAMETERS ### -ServiceTag diff --git a/Documentation/Functions/Invoke-OMEMcmGroupRetireLead.md b/Documentation/Functions/Invoke-OMEMcmGroupRetireLead.md index 85befe7..e0269a0 100644 --- a/Documentation/Functions/Invoke-OMEMcmGroupRetireLead.md +++ b/Documentation/Functions/Invoke-OMEMcmGroupRetireLead.md @@ -8,7 +8,7 @@ schema: 2.0.0 # Invoke-OMEMcmGroupRetireLead ## SYNOPSIS -Assign backup lead chassis to MCM Group +Retire lead chassis in MCM Group ## SYNTAX @@ -18,7 +18,7 @@ Invoke-OMEMcmGroupRetireLead [[-PostRetirementRoleType] ] [-Wait] [[-Wai ``` ## DESCRIPTION -This script uses the OME REST API to create mcm group, find memebers and add the members to the group. +This script uses the OME REST API to reture lead chassis ## EXAMPLES diff --git a/RELEASE.md b/RELEASE.md index 6982fab..a1136d2 100644 --- a/RELEASE.md +++ b/RELEASE.md @@ -22,9 +22,9 @@ ## Commit Changes ``` +git commit -m 'Release 2.3.1' git checkout main git merge devel -git commit -m 'Release 2.3.1' # Only tag releases as this triggers a git workflow (.github/workflows/create-release.yml) git tag v2.3.1