Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin vs workflow execution order #242

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Fix plugin vs workflow execution order #242

merged 8 commits into from
Nov 27, 2024

Conversation

Mai98
Copy link
Contributor

@Mai98 Mai98 commented Sep 30, 2024 •
edited
Loading

Fixes #94

  • Rewrite PluginManager to collect synchronous trigger functionality within one function
  • Use new function to execute plugins with execution order zero first. Then real-time workflows. Then remaining synchronous plugins.
  • Update postImage after synchronous logic have executed and save it in a new dedicated variable
  • Align 'StageAsync' with rewritten function 'TriggerSync'
  • Test using existing plugins and workflows as well as one new plugin with execution order zero

@Mai98 Mai98 marked this pull request as ready for review September 30, 2024 14:31
@mkholt mkholt merged commit 3da63a8 into master Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin vs Workflow execution order
2 participants
@Mai98 @mkholt