You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using dekorate.docker.registry=localhost:3000 and dekorate.docker.docker-file=src/main/resources/Dockerfile the registry only seems populated properly if there is a file in the module root called Dockerfile.
In the generated META-INF/dekorate/kubernetes.yaml, the presence of a Dockerfile in the module root seems to have an impact on what registry is used for the image in the kubernetes.yaml.
If there is a Dockerfile, as expected, kubernetes.yml contains:
As-is, it will fail. If you rename _Dockerfile to Dockerfile, it passes. Something seems to be going on during the merging and generating the Kubernetes manifest, but I can't quite put my finger on what is going wrong.
The text was updated successfully, but these errors were encountered:
kabir
added a commit
to kabir/dekorate
that referenced
this issue
Jun 9, 2022
When using
dekorate.docker.registry=localhost:3000
anddekorate.docker.docker-file=src/main/resources/Dockerfile
the registry only seems populated properly if there is a file in the module root called Dockerfile.In the generated META-INF/dekorate/kubernetes.yaml, the presence of a Dockerfile in the module root seems to have an impact on what registry is used for the image in the kubernetes.yaml.
If there is a Dockerfile, as expected, kubernetes.yml contains:
If there is no Dockerfile, kubernetes.yml contains the following instead (note 'localhost:3000' is now 'kabir' instead):
In both cases the generated docker.yml contains the following information (which is correct as far as I can tell):
I've added a test demonstrating the behaviour at https://github.com/dekorateio/dekorate/compare/main...kabir:issue-1000%3Dtest?expand=1. This is an adjusted copy of issue-420-docker-registry.
As-is, it will fail. If you rename
_Dockerfile
toDockerfile
, it passes. Something seems to be going on during the merging and generating the Kubernetes manifest, but I can't quite put my finger on what is going wrong.The text was updated successfully, but these errors were encountered: