Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor complex validation processing logic #1382

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

samayer12
Copy link
Collaborator

Description

Addresses complexity in validate-processor.ts

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #1381
Relates to #1248

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@samayer12 samayer12 changed the title Initial refactor to separate processing function chore: refactor complex validation processing logic Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.97%. Comparing base (c84043e) to head (155ddcb).

Files with missing lines Patch % Lines
src/lib/validate-processor.ts 20.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
+ Coverage   78.32%   78.97%   +0.64%     
==========================================
  Files          36       36              
  Lines        1698     1698              
  Branches      379      379              
==========================================
+ Hits         1330     1341      +11     
+ Misses        366      355      -11     
  Partials        2        2              
Files with missing lines Coverage Δ
src/lib/validate-processor.ts 42.10% <20.00%> (+28.94%) ⬆️

@samayer12
Copy link
Collaborator Author

On hold in favor of #1402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Refactor complex implementation in validate-processor.ts
1 participant