-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove model weights from container images #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YrrepNoj
commented
Jul 16, 2024
CollectiveUnicorn
requested changes
Jul 22, 2024
CollectiveUnicorn
previously approved these changes
Jul 22, 2024
YrrepNoj
force-pushed
the
breaking-models-out-POC
branch
from
July 25, 2024 21:41
c296723
to
977ea1e
Compare
YrrepNoj
dismissed
CollectiveUnicorn’s stale review
July 26, 2024 15:20
The base branch was changed.
YrrepNoj
force-pushed
the
breaking-models-out-POC
branch
from
July 26, 2024 15:22
285d451
to
a1811f1
Compare
✅ Deploy Preview for leapfrogai-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
YrrepNoj
force-pushed
the
breaking-models-out-POC
branch
3 times, most recently
from
July 30, 2024 18:15
148a648
to
f67a509
Compare
YrrepNoj
changed the title
chore: Proof of concept: Remove model weights from container images
chore: Remove model weights from container images
Jul 30, 2024
The Dockerfiles still contain a lot of extra ENVs and ARGs. I recommend removal and an update of the READMEs to add instructions for switching models and also any other mechanics that need to be explained to potential delivery engineers or users that use these. |
YrrepNoj
commented
Jul 31, 2024
…building zarf packages
YrrepNoj
force-pushed
the
breaking-models-out-POC
branch
from
July 31, 2024 22:08
943d983
to
742cf4c
Compare
justinthelaw
approved these changes
Jul 31, 2024
CollectiveUnicorn
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proof of concept to how we can utilize Zarf Data Injections to push model weights to a PVC instead of directly building them into the Docker images themselves.
Pros:
main
. This is about a 30% speedup for this workflow step.Cons:
dev
optional-dependencies listed in thepyproject.toml
being installed on the host machine during thezarf package create
lifecycle.