Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper version bounds from black and mypy #869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vuizur
Copy link

@Vuizur Vuizur commented Aug 30, 2023

Pull request title

  • I read contributing guideline
  • I didn't find a similar pull request already open.
  • My PR is related to Spleeter only, not a derivative product (such as Webapplication, or GUI provided by others)

Description

This removes the upper bounds from the tools black and mypy. This upper bound caused poetry to install old versions of these libraries, which have the deprecated library typed_ast as a dependency. Trying to install this library on a system with a newer Python version (for example 3.10) causes the attempt to compile the wheel for typed_ast, which fails with an error message like this: python/typed_ast#126

This PR fixes this issue, as newer versions of black and mypy don't require typed_ast anymore.

How this patch was tested

  • I implemented unit test whicn ran successfully using poetry run pytest tests/
  • Code has been formatted using poetry run black spleeter
  • Imports has been formatted using `poetry run isort spleeter``

Documentation link and external references

Please provide any info that may help us better understand your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant