Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoMerging-Retriever: support more document stores #8310

Closed
davidsbatista opened this issue Aug 29, 2024 · 2 comments
Closed

AutoMerging-Retriever: support more document stores #8310

davidsbatista opened this issue Aug 29, 2024 · 2 comments
Assignees
Labels
P2 Medium priority, add to the next sprint if no P1 available

Comments

@davidsbatista
Copy link
Contributor

davidsbatista commented Aug 29, 2024

@davidsbatista davidsbatista self-assigned this Aug 29, 2024
@julian-risch julian-risch added the P2 Medium priority, add to the next sprint if no P1 available label Sep 3, 2024
@davidsbatista
Copy link
Contributor Author

  • We decided to put PineCone fix on hold - we now the AutoMergingRetriever doesn't work with Pinecone and why, if there's ever such a user case we pick this issue again

@davidsbatista
Copy link
Contributor Author

Weaviate as a similar issue, the python client as 3 methods to query/fetch:

  • fetch_objects()
  • fetch_object_by_id()
  • fetch_objects_by_ids()
    However, Haystack implementation only uses fetch_objects()

Another note, it seems the original Document id is also stored in the metadata as _original_id, another possible hack would be to catch when the id is part of the filter, and map it to the _original_id in the metadata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority, add to the next sprint if no P1 available
Projects
None yet
Development

No branches or pull requests

2 participants