Chore: refactor LinearAtomicModel serialize/deserialize #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
anyangml
commented
Mar 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3451 +/- ##
==========================================
- Coverage 77.34% 77.34% -0.01%
==========================================
Files 428 428
Lines 37001 37005 +4
Branches 1621 1621
==========================================
+ Hits 28619 28621 +2
- Misses 7514 7516 +2
Partials 868 868 ☔ View full report in Codecov by Sentry. |
anyangml
commented
Mar 12, 2024
wanghan-iapcm
approved these changes
Mar 12, 2024
for more information, see https://pre-commit.ci
wanghan-iapcm
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
This PR provides a default weight computing method for the linear model (average over all sub-models) to make it instantiable. @njzjz please check if it a good design
njzjz
requested changes
Mar 12, 2024
njzjz
requested changes
Mar 12, 2024
for more information, see https://pre-commit.ci
njzjz
reviewed
Mar 13, 2024
njzjz
approved these changes
Mar 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the serialization/ deserialization in LinearEnergyAtomicModel using the plugin mechanism introduced in #3438 .