pt: improve nlist performance #3425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. use inv_ex instead of inv. `inv_ex` does not check errors. We can assume the input is correct. 2. copy nbuff from device to host once other than 6 times (although copying once is still slow); 3. avoid torch.tensor. Signed-off-by: Jinzhe Zeng <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #3425 +/- ##
==========================================
+ Coverage 76.95% 76.98% +0.03%
==========================================
Files 423 423
Lines 35883 35956 +73
Branches 1620 1621 +1
==========================================
+ Hits 27612 27679 +67
- Misses 7403 7409 +6
Partials 868 868 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <[email protected]> (cherry picked from commit a560f549b340c90af88b8831113445b17a0863c0)
Signed-off-by: Jinzhe Zeng <[email protected]>
wanghan-iapcm
approved these changes
Mar 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inv_exdoes not check errors. We can assume the input is correct.torch.arange;