Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Interface/Internal precision design & consistency #4265

Closed
iProzd opened this issue Oct 28, 2024 · 1 comment · Fixed by #4344 or #4343
Closed

[Feature Request] Interface/Internal precision design & consistency #4265

iProzd opened this issue Oct 28, 2024 · 1 comment · Fixed by #4344 or #4343
Labels
enhancement
Milestone
v3.0.0

Comments

@iProzd
Copy link
Collaborator

iProzd commented Oct 28, 2024

Summary

Design&Make interface/internal precision consistent between all modules in pt/dp and se_a in pt/dp/tf.

Detailed Description

See above.

Further Information, Files, and Links

No response
@iProzd iProzd moved this to mustfix in DeePMD-kit V3.0.0 RC Oct 28, 2024
@njzjz njzjz added this to the v3.0.0 milestone Oct 28, 2024
@njzjz
Copy link
Member

njzjz commented Nov 15, 2024

Fixed by #4343 and #4344.

@njzjz njzjz closed this as completed Nov 15, 2024
@github-project-automation github-project-automation bot moved this from mustfix to Done in DeePMD-kit V3.0.0 RC Nov 15, 2024
This was linked to pull requests Nov 15, 2024
fix(pt): fix precision #4344
Merged
fix(dpmodel): fix precision #4343
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Multiple backend support for DeePMD-kit
Archived in project
DeePMD-kit V3.0.0 RC
Status: Done
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

fix(pt): fix precision iProzd/deepmd-kit
fix(dpmodel): fix precision njzjz/deepmd-kit
2 participants
@njzjz @iProzd