Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save to the model in UpdateSel.hook #3525

Closed
github-actions bot opened this issue Mar 19, 2024 · 1 comment · Fixed by #3829
Closed

save to the model in UpdateSel.hook #3525

github-actions bot opened this issue Mar 19, 2024 · 1 comment · Fixed by #3829
Assignees
@njzjz
Labels
branch: devel todo comment type: todo

Comments

@github-actions
Copy link

Line: 20
https://github.com/deepmodeling/deepmd-kit/blob/76371ceed2fd0d8e259e482e046da350d4006c0a//deepmd/dpmodel/utils/update_sel.py#L17-L27
@njzjz njzjz self-assigned this Mar 19, 2024
njzjz added a commit to njzjz/deepmd-kit that referenced this issue May 28, 2024
@njzjz
refactor: refactor update_sel and save min_nbor_dist
e97bf96 
Fix deepmodeling#3525. Fix deepmodeling#3544.

Signed-off-by: Jinzhe Zeng <[email protected]>
@njzjz njzjz mentioned this issue May 28, 2024
Merged
@njzjz njzjz linked a pull request May 28, 2024 that will close this issue
refactor: refactor update_sel and save min_nbor_dist #3829
Merged
github-merge-queue bot pushed a commit that referenced this issue May 31, 2024
@njzjz @wanghan-iapcm
refactor: refactor update_sel and save min_nbor_dist (#3829)
3a7fbcf 
Fix #3525. Fix
#3544.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced `update_sel` method to accept additional parameters and
return more detailed data, improving model selection and neighbor
statistics.
- **Bug Fixes**
- Improved handling and processing of training data to enhance model
accuracy.
- **Refactor**
- Updated method signatures and logic for consistency and better
performance.
- **Chores**
  - Removed unused `hook` method to streamline codebase.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
Co-authored-by: Han Wang <[email protected]>
@github-actions GitHub Actions
Copy link
Author

Closed in commit 3a7fbcf

mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this issue Sep 18, 2024
@njzjz @wanghan-iapcm
refactor: refactor update_sel and save min_nbor_dist (deepmodeling#3829)
9332a06 
Fix deepmodeling#3525. Fix
deepmodeling#3544.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced `update_sel` method to accept additional parameters and
return more detailed data, improving model selection and neighbor
statistics.
- **Bug Fixes**
- Improved handling and processing of training data to enhance model
accuracy.
- **Refactor**
- Updated method signatures and logic for consistency and better
performance.
- **Chores**
  - Removed unused `hook` method to streamline codebase.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <[email protected]>
Co-authored-by: Han Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njzjz njzjz

Labels
branch: devel todo comment type: todo
Projects
No open projects
DeePMD-3.0.0 beta release
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: refactor update_sel and save min_nbor_dist njzjz/deepmd-kit
1 participant
@njzjz