Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up the init interface of pt.dataloader #3427

Closed
wanghan-iapcm opened this issue Mar 7, 2024 · 1 comment · Fixed by #3434
Closed

clean up the init interface of pt.dataloader #3427

wanghan-iapcm opened this issue Mar 7, 2024 · 1 comment · Fixed by #3434

Comments

@wanghan-iapcm
Copy link
Collaborator

wanghan-iapcm commented Mar 7, 2024

Summary

The initialization of a dataloader needs a dict named model_param .

def __init__(
self,
systems,
batch_size,
model_params,
seed=10,
shuffle=True,
):

this is not a good design, we should explicitly write what information is necessary to init the dataloader. The doc str is also missing...

DeePMD-kit Version

v3.0.0.a0

TensorFlow Version

2.14.0

Python Version, CUDA Version, GCC Version, LAMMPS Version, etc

No response

Details

As described in summary.

@wanghan-iapcm
Copy link
Collaborator Author

fixed via #3434

github-merge-queue bot pushed a commit that referenced this issue Mar 8, 2024
#3427

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants