Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header parsing in LMA reader #6

Open
deeplycloudy opened this issue Jul 11, 2019 · 1 comment
Open

Header parsing in LMA reader #6

deeplycloudy opened this issue Jul 11, 2019 · 1 comment

Comments

@deeplycloudy
Copy link
Owner

This issue consolidates a few things discussed in #2. Quoting:

Potential issue: Header information (station locations, % contributions, etc.) are read in with a fixed width format since station names may white space. I'm unsure how consistent those widths are among existing file formats. — @vbalderdash

there's no Data format: 15.9f 12.8f 13.8f 9.2f 6.2f 5.1f 7x line like there is for the main data section. I think we just live with it. Maybe there are some simple checks that could be done to throw a warning / error if, say, lon lat for stations aren't close to the coord center. —@deeplycloudy

Maybe an check on whether the values read in are floats/strings would work? Pandas can infer the widths instead of specifying it. I have not had luck with that method, but maybe it's something that would be useful to troubleshoot. — @vbalderdash

@deeplycloudy
Copy link
Owner Author

As mentioned in #9, since there are a few flavors of data file in the wild, it would be good to include a truncated (a few data points) data file of each kind in the repository, and attach some testing infrastructure to make sure that future changes to the reader don't accidentally break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant