Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filtering flashes is not possible without running flash stats, even if the filter doesn't require it #47

Open
wx4stg opened this issue Aug 7, 2024 · 0 comments

Comments

@wx4stg
Copy link
Contributor

wx4stg commented Aug 7, 2024

in #26, we introduced a check to not allow filtering by flashes unless flash_stats had been called first.

This check is too aggressive, as its possible to filter by some parameters (number of points per flash) without calculating flash stats first. From lmaworkshop:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant