Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on record #72

Closed
esturniolo opened this issue Oct 1, 2023 · 9 comments
Closed

Error on record #72

esturniolo opened this issue Oct 1, 2023 · 9 comments

Comments

@esturniolo
Copy link

When you try to record a radio that transmit in another codec than mp3, it will fail.
https://imgur.com/LDu7pbt

May be using -c:a libmp3lame in the ffmpeg record command will help.
The previuos flag change the codec to mp3.

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Hi, @esturniolo,
Thanks for your contribution 💙 .
Contributors 🧑‍🤝‍🧑 like you make the open source community 🌍 such an amazing place to learn 📖 , inspire 👼, and create 🎨 .
We will investigate 👀 and get back to you as soon as possible 👍 . Just make sure you have given us sufficient information ℹ️.

By that time enjoy this meme 👇 , hope you like it 😄

meme

Use this action on your projects. Use jokes on issues instead.

@deep5050
Copy link
Owner

deep5050 commented Oct 1, 2023

duplicate of #68
yes i have checked with libmp3lame it works as expected 🎉 . Thank you so much for the trick!

will support on 2.7.1

@deep5050
Copy link
Owner

deep5050 commented Oct 2, 2023

hi, @esturniolo would you please try this insider version and give feedback about the recording feature?
by default, it would record mp3,. if -filetype auto is provided it will try to detect the codec information from the URL and set the extension accordingly!

pip install git+https://github.com/deep5050/[email protected]

@esturniolo
Copy link
Author

I'll.
If you can, please give me a few days.

I'm glad that the libmp3lame worked!

@deep5050 deep5050 closed this as completed Oct 5, 2023
@esturniolo
Copy link
Author

The recording feature now works as expected.
Thanks!

But I've another question regarding the recording.
I see that this new version doesn't show the UUID anymore, so how can I select the proper station to recording programatically?

@deep5050
Copy link
Owner

deep5050 commented Oct 6, 2023

actually, the table with UUID takes up a lot of space. I was planning to ignore it completely.

you can suggest me weather I should display UUID or not.

@esturniolo
Copy link
Author

esturniolo commented Oct 6, 2023

I understand, but I think that this info is needed in order to record something in the background.
What about if you use on the last characters of the UUID in the screen, but pointing to the real one?

I mean you have this UUID 5517c22e-6453-11ee-8c99-0242ac120002

But in the screen you show:

┃ ID ┃ Station                        ┃ Country ┃ UUID              |         Tags                     ┃
┡━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ 1  │ Spoon                          │         │ 0242ac120002      |                                    │

If not, there is another way to record in the background?

@deep5050
Copy link
Owner

deep5050 commented Oct 6, 2023

We can show the UUID after we select a station. Or introduce an option to show detailed search results.

@esturniolo
Copy link
Author

The idea to add an option to show the detailed view in resutls sounds great!
So every user select what to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants