Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to "--list" flag #104

Closed
robinhood2014 opened this issue Nov 14, 2023 · 2 comments
Closed

Improvement to "--list" flag #104

robinhood2014 opened this issue Nov 14, 2023 · 2 comments

Comments

@robinhood2014
Copy link

Right now, radio --list shows the user's list of favorite stations and then drops them right back to the shell. Perhaps we could improve the --list flag so it asks the user if (s)he wants to play a station from that list? We could attach numbers to the favorites list, and the user could just input the number of the station (s)he wants (or, say, 0 to go back to the shell as before).

On a related note, we could also improve the question Type the result ID to play: so it will actually accept 0 as a valid input to go back to the shell. This already does work, but the program also prints error messages at the end before dropping to the shell. Perhaps the user legitimately changed his/her mind and didn't want to play anything? In that case, if (s)he enters 0, don't print the unnecessary error messages.

Copy link

Hi, @robinhood2014,
Thanks for your contribution 💙 .
Contributors 🧑‍🤝‍🧑 like you make the open source community 🌍 such an amazing place to learn 📖 , inspire 👼, and create 🎨 .
We will investigate 👀 and get back to you as soon as possible 👍 . Just make sure you have given us sufficient information ℹ️.

By that time enjoy this meme 👇 , hope you like it 😄

meme

Use this action on your projects. Use jokes on issues instead.

@deep5050
Copy link
Owner

invoking radio without any options allows you to select a station from your favorite menu already. I don't think we should unnecessarily play from the favorite list table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants