Removed Dates and Update Status for Continuous Journal #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @amritpurshotam would you mind reviewing this PR please? |
amritpurshotam
requested changes
Mar 5, 2023
There was a problem hiding this comment.
Nice work @shreyalpandit !. Just some small changes to clean up the Event construction and some optional changes for each of the @property fields. Otherwise looks good :)
Comment on lines
+15
to
+23
| def check_open(open, close): | ||
| now = datetime.now() | ||
| if open and close: | ||
| return now >= open and now < close | ||
| elif open: | ||
| return now >= open | ||
| elif close: | ||
| return now < close | ||
| return True |
There was a problem hiding this comment.
I like this, much much cleaner than what I suggested!
amritpurshotam
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #1090 so that the continuous journal does not have a value for all dates except start date.