Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credits page avatars shrink on long names #762

Closed
marijnvdwerf opened this issue May 16, 2023 · 4 comments · Fixed by #1219
Closed

Credits page avatars shrink on long names #762

marijnvdwerf opened this issue May 16, 2023 · 4 comments · Fixed by #1219

Comments

@marijnvdwerf
Copy link
Collaborator

image

@marijnvdwerf
Copy link
Collaborator Author

Might be an idea to not have them as columns, but have them wrap, just like the buttons below? Would need some more spacing to make it feel less awkward.

image

@bates64
Copy link
Member

bates64 commented May 16, 2023

I like that, like flexbox space-between or something. Should make sure everything incl the images are flex-shrink: 0 to fix this

@marijnvdwerf
Copy link
Collaborator Author

image

I played around in devtools a bit. Something like this looks a lot calmer to me. I added a column-gap: 8px; row-gap: 4px; margin: 0 -8px; to the container, and removed the @ signs. Sorted by people with/without avatars for a more structured look.

Example with @-signs kept:
image

@bates64
Copy link
Member

bates64 commented May 16, 2023

Both look great!

The reason for the @ in the design is to make it inferable that users can type @username in a #128 or description but that isn't actually supported yet, so I don't mind dropping them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants