depricated api fix #125
Closed
depricated api fix #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration send_to_topic_condition for v1
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -226,7 +237,8 @@ def for_uri(uri, extra_headers = {}) | |||
| ) do |faraday| | |||
| faraday.adapter Faraday.default_adapter | |||
| faraday.headers["Content-Type"] = "application/json" | |||
| faraday.headers['Authorization'] = "key=#{@api_key}" | |||
| faraday.headers["Authorization"] = "Bearer #{jwt_token}" | |||
| faraday.headers["access_token_auth"]= "true" | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Layout/SpaceAroundOperators: Surrounding space missing for operator =.
| @@ -226,7 +237,8 @@ def for_uri(uri, extra_headers = {}) | |||
| ) do |faraday| | |||
| faraday.adapter Faraday.default_adapter | |||
| faraday.headers["Content-Type"] = "application/json" | |||
| faraday.headers['Authorization'] = "key=#{@api_key}" | |||
| faraday.headers["Authorization"] = "Bearer #{jwt_token}" | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -217,6 +215,19 @@ def send_to_topic_condition(condition, options = {}) | |||
| end | |||
| end | |||
|
|
|||
| def send_to_topic_condition_v1(condition, options = {}) | |||
| if validate_condition?(condition) | |||
There was a problem hiding this comment.
Style/GuardClause: Use a guard clause instead of wrapping the code inside a conditional expression.
|
Thanks for this @aap17 Can you please update the tests before we merge this? |
|
ah looks like this PR #123 also has tests in addition to this PR. So gonna close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currenly the lib uses depricated Google API for topic management. We have fixed it
#122