Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing or renaming Key trait's alias() method #206

Open
KendallWeihe opened this issue May 14, 2024 · 0 comments
Open

Consider removing or renaming Key trait's alias() method #206

KendallWeihe opened this issue May 14, 2024 · 0 comments

Comments

@KendallWeihe
Copy link
Contributor

Originally spurred here #204

What is the purpose of the .alias() method in the Key trait? Is it a unique digest? Whatever it is, we should probably rename the method.

It's unclear what the ideal design here is.

  • Open question 1: it's a good point... the way I think about it is, the key alias is akin to a primary key in a db, so it's self referential with respect to a key. It's slightly confusing though because we enable callers of key manager methods to override the key alias, so it's a matter which is conceptualized at the key manager level, but at the same time we implement the alias for the Jwk which is the thumbprint. 🤔
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant