Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical clipping attribute is not taking into consideration for LODS #1882

Open
dalkia opened this issue Aug 26, 2024 · 2 comments · May be fixed by decentraland/asset-bundle-converter#153
Open

Vertical clipping attribute is not taking into consideration for LODS #1882

dalkia opened this issue Aug 26, 2024 · 2 comments · May be fixed by decentraland/asset-bundle-converter#153
Assignees
@davidejensen
Labels
1-high Very important but not critical or game breaking bug Something isn't working
Milestone
Beta Release

Comments

@dalkia
Copy link
Collaborator

dalkia commented Aug 26, 2024 •
edited
Loading

Vertical clipping only works with the scene-shader at runtime. LODs clipping values are set in the asset-bundle converter. We should add the calculation there as well
@dalkia dalkia added bug Something isn't working 1-high Very important but not critical or game breaking labels Aug 26, 2024
@dalkia dalkia self-assigned this Aug 26, 2024
@github-actions github-actions bot added the new Issues to triage label Aug 26, 2024
@dalkia dalkia changed the title Vertical clipping attribute is not present in all materials Vertical clipping attribute is not taking into consideration for LODS Aug 27, 2024
@aixaCode aixaCode removed the new Issues to triage label Aug 28, 2024
@m3taphysics
Copy link
Collaborator

Another bit of knowledge expansion for you @davidejensen!

@davidejensen
Copy link
Member

Changes applied in decentraland/asset-bundle-converter#153

Tested with:

  • airdrop tower
  • Giant estate -27,-17
    Image
  • SuperRare Museum 55,94
    Image
  • PixelChain 52,95
    Image

@davidejensen davidejensen linked a pull request Sep 27, 2024 that will close this issue
Open
@aixaCode aixaCode added this to the Beta Release milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidejensen davidejensen

Labels
1-high Very important but not critical or game breaking bug Something isn't working
Projects
Explorer Alpha
Status: With QA / Awaiting Review
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

fix: added vertical clipping handling for lods decentraland/asset-bundle-converter
4 participants
@m3taphysics @dalkia @davidejensen @aixaCode