Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Scene failing by timeout doesn't notify the renderer #627

Open
kuruk-mm opened this issue Oct 25, 2022 · 0 comments
Open

Scene failing by timeout doesn't notify the renderer #627

kuruk-mm opened this issue Oct 25, 2022 · 0 comments

Comments

@kuruk-mm
Copy link
Member

When a scene fails for timeout:

const WORKER_TIMEOUT = 90_000 // three minutes
setTimeout(() => {
if (!this.sceneStarted) {
this.ready |= SceneWorkerReadyState.LOADING_FAILED
workerStatusObservable.notifyObservers(signalSceneFail(this.loadableScene))
}
}, WORKER_TIMEOUT)

The renderer doesn't get notified about it, and the loading gets stuck forever.

Example coordinates: "-20,26", "-19,26", "-20,27", "-19,27", "-29,26".

Note: This issue doesn't try to fix the issue in the scene itself. It's a fix for the explorer.

Partial fix from: decentraland/explorer-desktop#386

@kuruk-mm kuruk-mm transferred this issue from decentraland/sdk Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants