Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-mass-change flag to atomMapping script #49

Open
pbuslaev opened this issue Aug 20, 2024 · 0 comments
Open

Add --no-mass-change flag to atomMapping script #49

pbuslaev opened this issue Aug 20, 2024 · 0 comments

Comments

@pbuslaev
Copy link

While mapping atoms with different masses is reasonable in many cases, it can be handy to have an option for not doing so. The reason, is that mass changes are not supported in GROMACS on GPU at the moment. While it can change in the future, for now those changes are only possible with update step on CPU, which blocks efficient running in the cloud. I gave it a try locally, by postprocessing created pairs to remove atoms with different masses and hydrogens attached to those from the mapping. I did not observe any significant performance degradation. Since I was not really interested in the score, I was not updating it.

The plan for the change can be:

  • Add a flag
  • Add a check for mapped atoms to have similar mass
  • Exclude hydrogens from mapping, if they are accidentally mapped (e.g. CH3 -> NH3+)
  • Update score

@vgapsys If the plan sounds reasonable, I can start working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant