-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write variable length lists (tinyply 2.0) #17
Comments
Actually it would be nice if both was possible, variable-length ( |
Hi @caselitz variable length lists are fairly uncommon and so I haven't put much time towards supporting them in this library. I re-wrote some inner loops of tinyply 2.0 to better support these in the future (i.e. they do not work today) but I need to loop back and actually write the functionality. I believe @bchretien has a fork of tinyply which actually does work. |
Thanks for your quick reply and the clarification (and of course for providing the library)! I feel the description in the readme regarding the variable length lists might be a bit misleading (at least I misunderstood it). Anyhow, I think supporting them would be a great feature for the future since they are, even though possibly uncommon, part of the PLY format. PS: I ended up using the old version with the stuff from bchretiens fork, seems to work nicely. :) |
Hi @caselitz -- It sounds like you're unblocked on this feature already from bchretien's fork, but if you're feeling adventurous I just pushed preliminary support for this feature on a branch: https://github.com/ddiakopoulos/tinyply/tree/variable-length |
Out of pure curiosity, in what context do you use / need variable length lists? It sounds so exotic to me. It seems for quad support? |
@svenevs The only rational thing I can think of is given by the example in the PLY spec. Mixed uses of triangles and quads. |
That's great, thank's for your effort! I will try it, hope to find the time soon...
I'm saving a list of objects in the PLY and each object is a set of (arbitrary many) vertices whose vertex_indices I store - so in my code I have a I think this is within the scope of the PLY format. Quote from here
|
I found the time to test @ddiakopoulos. The reading works fine for me (only the debug output should be removed). However, the writing does not work. Have you implemented/adapted that already? At least there is no adaption in the example and also the basic example fails (segfault, core dump). |
I saw some recent activity in the repo. Any progress on this issue here @ddiakopoulos? Maybe it would be a nice thing to include in tinyply 2.1 Thanks, |
@caselitz working on it for 2.2 :) Long tail is not the actual implementation itself but testing it adequately |
this is not included in 2.2, right? any chance for 2.3? :) |
@caselitz yes, 2.3 will entirely be dedicated to variable length! |
Any hope for 2.3 @ddiakopoulos? Thanks, |
So now I'm hoping for 2.4 (saw a commit in the branch), great that you found time to work on the library again... thanks! :) |
Hi,
the readme of tinyply 2.0 states:
Unfortunately there is no example how to write (and read) a variable length list in the example. I wonder how this works. I would basically like to write/read this
where lists should be represented by a
std::vector<std::vector<T>>
. Is this supported by tinyply 2.0?I also saw this was discussed here and here but this is quite old and it is not clear to me what ended up in upstream (branch 2.0) and what is only available in some forks etc.?
The text was updated successfully, but these errors were encountered: