Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump payload hook function: conversion to object #19

Open
charlesreid1 opened this issue Sep 11, 2018 · 0 comments
Open

Dump payload hook function: conversion to object #19

charlesreid1 opened this issue Sep 11, 2018 · 0 comments

Comments

@charlesreid1
Copy link
Contributor

This is our simplest hook function.

We need it to do a couple of things:

  • identify, as best it can, certain types of webhooks
  • log the webhook payload and write it to a file (NOTE: preferably a SEPARATE directory)
  • design this as an object

this will be a good starting point for a base class, and we can build in more functionality with derived classes as we go.


What will the base class implement?

  • boolean methods: is this a pull request, is this a merge, is this an X, a Y, whatever
  • method to log payload
  • logging functionality (using module-named logger)

utility methods:

  • get a timestamp for a label

next steps?

(virtual) python test class:

  • all python tests are virtual
  • all paths are absolute
  • runs virtualenv in some directory, IDK
  • defines a bindir, where mkdocs and python and pip are all accessible
  • covers mkdocs pull requests, snakemake builds
  • covers anything with a requirements.txt
  • resolves an existing issue with uncle archie and oyaml in the dcppc/private-www repo
@charlesreid1 charlesreid1 changed the title Dump Payload hook function Dump payload hook function: conversion to object Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant