-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add token encryption capabilties #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g tokens will need removing if enabling this, disabled by default. Tidy up connect function, if it has code run method, else it doesn't have the code so run second method, no need for a condition.
@dcblogdev please can you merge? |
due to the last PR can you fix the merge conflict? if possible can you add some tests? |
Will do!
…On Sat, Sep 9, 2023 at 2:15 PM David Carr ***@***.***> wrote:
due to the last PR can you fix the merge conflict? if possible can you add
some tests?
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKWBFR5JN3RHHTMX4JNSDLXZRTW7ANCNFSM6AAAAAAZZRSPDQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Tony Partridge
Xtech Web Services Ltd
Managing Director/Developer
|
@dcblogdev now updated encryption with a couple of tests too. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small code tidy up (Thanks to Pint) and enable encryption of tokens in the DB Level.
Note, not yet tested fully. Please run your standard tests :-)
Existing tokens will need wiping as the Crypt class falls over if it doesn't match a Crypt store.