Update and rename RadarBotList.ts to Radarcord.ts #575
+136
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndBug
requested changes
Jan 26, 2023
Comment on lines
+107
to
+121
| /** | ||
| * Returns a 1 or 0 depending on whether the user has voted for the bot | ||
| * @param botID The bot's ID | ||
| * @param userID The user's ID | ||
| */ | ||
| getBotVotes(botID: IDResolvable, userID: IDResolvable) { | ||
| return this._request( | ||
| { | ||
| url: `/hasvoted/${Util.resolveID(userID)}/${Util.resolveID(botID)}` | ||
| }, | ||
| { | ||
| requiresToken: false | ||
| } | ||
| ) | ||
| } |
There was a problem hiding this comment.
Suggested change
| /** | |
| * Returns a 1 or 0 depending on whether the user has voted for the bot | |
| * @param botID The bot's ID | |
| * @param userID The user's ID | |
| */ | |
| getBotVotes(botID: IDResolvable, userID: IDResolvable) { | |
| return this._request( | |
| { | |
| url: `/hasvoted/${Util.resolveID(userID)}/${Util.resolveID(botID)}` | |
| }, | |
| { | |
| requiresToken: false | |
| } | |
| ) | |
| } |
This is a duplicate from above
| @@ -66,11 +66,70 @@ export default class RadarBotDirectory extends Service { | |||
| getBotVotes(botID: IDResolvable, userID: IDResolvable) { | |||
| return this._request( | |||
| { | |||
| url: `/lastvoted/${Util.resolveID(userID)}/${Util.resolveID(botID)}`, | |||
| headers: { Authorization: this.token } | |||
| url: `/lastvoted/${Util.resolveID(userID)}/${Util.resolveID(botID)}` | |||
There was a problem hiding this comment.
Is this endpoint still in the API? Where is it documented in the docs?
Also, it's using the same name as below
There was a problem hiding this comment.
It's an API endpoint, just reminded me to add it to the documentation.
Should be called lastVoted() or something similar
There was a problem hiding this comment.
Yup, lastVoted() will be fine 👍🏻
Co-authored-by: Federico Grandi <[email protected]>
Co-authored-by: Federico Grandi <[email protected]>
Co-authored-by: Federico Grandi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.