-
Notifications
You must be signed in to change notification settings - Fork 2
Bootstrap update to v5 of recipe, dish and purchase list editor #183
base: master
Are you sure you want to change the base?
Conversation
@dboehmer The update of the purchase list editor makes 1 test failing "change item total" from t/controller_Item.t. As far as I understand the test it should work, but it could be that the test references a wrong form in line 52. So could you please check this.- |
I tried to change arguments to |
Before the update the form only had a name ("total") (which would also not be unique when we have multiple items on our purchase list) and no id. I added the id so that I can use the form elements outside with the form attribute. The unit conversion form works also with this approach (form elements outside the form), but maybe this form is not covered by any test. |
If I test the total form by hand it works. |
Here are some information about the form attribute on form elements. |
background-color: #4CAF50; | ||
} | ||
background-color: var(--cc-green); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing trailing newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the missing newline
I fixed the test. It looks like that Mechanize didn't support the form attribute on inputs. I think now is the branch ready to be merged |
Closes #130
Closes #131
Closes #133