Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Copy styling of "general information" inputs from recipe editor to dish editor #130

Open
dboehmer opened this issue Dec 17, 2020 · 2 comments · May be fixed by #183
Open

Copy styling of "general information" inputs from recipe editor to dish editor #130

dboehmer opened this issue Dec 17, 2020 · 2 comments · May be fixed by #183

Comments

@dboehmer
Copy link
Owner

Code should not be shared between both pages because there are slightly different inputs.

  • source: root/templates/recipe/edit.tt
  • target: root/templates/dish/edit.tt

Please wait for branch bootstrap to be merged in master and base your work on top of this.

@rico-hengst
Copy link
Collaborator

Current issue is realized.

About wording in template ''ingredients_editor.tt".
It should be noted, that the template ''ingredients_editor.tt" is used in

  • source template and
  • target template.

So the form and the button "Update Recipe" in the Ingredients panel appears in both templates.
The user of the dish editor will be confused if the phrase "Update Recipe" is used, .... maybe.

@dboehmer
Copy link
Owner Author

dboehmer commented Jan 9, 2021

Current issue is realized.

Thank you for taking care of this!

About wording in template ingredients_editor.tt.
It should be noted, that the template ingredients_editor.tt is used in

  • source template and
  • target template.

So the form and the button "Update Recipe" in the Ingredients panel appears in both templates.
The user of the dish editor will be confused if the phrase "Update Recipe" is used, .... maybe.

Very good point! I’ve just pushed a fix. Do a quick git pull before you continue work:-)

Let’s keep this issue open until it’s merged into master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants